pipelines: Support working directory in sign step #2156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
reviewed
Dec 9, 2025
| condition: and(succeeded(), eq(variables['signprojExists'], True)) | ||
| name: package | ||
| displayName: "\U0001F449 Get extension info from package.json" | ||
| workingDirectory: $(Build.SourcesDirectory) |
Contributor
There was a problem hiding this comment.
It's a little confusing why this step happens at the root, but subsequent ones at $(Build.SourcesDirectory)/${{ parameters.workingDirectory }}
Member
Author
There was a problem hiding this comment.
Weird because it seems like it worked fine but I would've assumed this would break it https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=12924123&view=artifacts&pathAsName=false&type=publishedArtifacts
Member
Author
|
Got this working now and tested for RGs, and both extensions in /azure. Doesn't require changes to the signproj file |
bwateratmsft
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for signing the helper extension for /azure which lives in a subdirectory of the root extension.
AI summary:
This pull request updates the Azure Pipelines signing workflow to support specifying a custom working directory for extension signing operations. This makes the pipeline more flexible and robust when handling extensions located in subdirectories or non-standard locations.
Pipeline configuration improvements:
workingDirectoryparameter to thesign.ymltemplate, allowing customization of the directory where signing operations and file lookups occur.sign.ymlto use the newworkingDirectoryparameter, ensuring that file operations such as manifest generation, signing, and verification are correctly scoped to the specified directory. [1] [2] [3]Integration with main pipeline:
workingDirectoryparameter from the main pipeline stage configuration to the signing template, enabling end-to-end support for directory customization.