Use v6 of auth package #1292
Draft
Use v6 of auth package #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
commented
Nov 20, 2025
| *--------------------------------------------------------------------------------------------*/ | ||
|
|
||
| import type { AzureSubscriptionProvider } from "@microsoft/vscode-azext-azureauth"; | ||
| import { type AzureDevOpsSubscriptionProviderInitializer, createAzureDevOpsSubscriptionProviderFactory } from "@microsoft/vscode-azext-azureauth/azdo"; |
Contributor
Author
There was a problem hiding this comment.
We should move this out so it's actually in the test code, and thus all the stuff doesn't get bundled.
bwateratmsft
commented
Dec 4, 2025
| await provider.signIn(); | ||
| } finally { | ||
| _isLoggingIn = false; | ||
| // TODO: do we need this or does the session change event take care of it? |
| let selectedTenant: TenantIdDescription | undefined = undefined; | ||
|
|
||
| const subscriptions = await subscriptionProvider.getSubscriptions(false); | ||
| const subscriptions = await subscriptionProvider.getAvailableSubscriptions({ filter: false }); |
Contributor
Author
There was a problem hiding this comment.
This can be reduced to just the getAvailableSubscriptions call
| } else { | ||
| // All tenants are authenticated but no subscriptions exist | ||
| // The prior behavior was to still show the Select Subscriptions item in this case | ||
| // TODO: this isn't exactly right? Should we throw a `NotSignedInError` instead? |
| for await (const tenant of tenants) { | ||
| const isSignedIn = await subscriptionProvider.isSignedIn(nonNullProp(tenant, 'tenantId'), account); | ||
| for await (const tenant of allTenants) { | ||
| // TODO: This is n^2 which is not great, but the number of tenants is usually quite small |
Contributor
Author
There was a problem hiding this comment.
TODO: Do? Tenants can be as high as 650+...
| return getSignInTreeItems(false); | ||
| } | ||
|
|
||
| // TODO: Else do we throw? What did we do before? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.