Skip to content

Conversation

@MicroFish91
Copy link
Contributor

No description provided.

@MicroFish91 MicroFish91 requested a review from a team as a code owner October 27, 2025 00:29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add resources/changelog/** to the vscodeignore?

Copy link
Contributor Author

@MicroFish91 MicroFish91 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - one question though, would the changelog images continue showing up in the marketplace page? Would I need to reference images using a GitHub web url instead?

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, that's a good question for Isidor. I'd expect full web links to work for sure though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot tells me full web links will work

Copy link
Contributor

@bwateratmsft bwateratmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold off, I need to fix microsoft/vscode-azuretools#2111.

Update: Fix in #1279

bwateratmsft
bwateratmsft previously approved these changes Oct 30, 2025
@MicroFish91 MicroFish91 enabled auto-merge (squash) October 30, 2025 16:31
@MicroFish91
Copy link
Contributor Author

Swapped to web links and updated the date!

@MicroFish91 MicroFish91 merged commit d757b51 into main Oct 30, 2025
3 checks passed
@MicroFish91 MicroFish91 deleted the mwf/elated-lavender branch October 30, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants