-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[glew] Add public definition GLEW_NO_GLU [colmap] Remove feature cuda #43641
Closed
WangWeiLin-MV
wants to merge
1
commit into
microsoft:master
from
WangWeiLin-MV:ports/freetype-gl/system-dependency-message
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
index 4f8d7dd..40d72f8 100644 | ||
--- a/CMakeLists.txt | ||
+++ b/CMakeLists.txt | ||
@@ -112,7 +112,7 @@ include_directories( | ||
${OPENGL_INCLUDE_DIRS} | ||
${FREETYPE_INCLUDE_DIRS} | ||
${CMAKE_CURRENT_SOURCE_DIR} | ||
- ${GLEW_INCLUDE_PATH} | ||
+ | ||
${PROJECT_BINARY_DIR} | ||
) | ||
|
||
@@ -196,7 +196,7 @@ target_link_libraries(freetype-gl | ||
${OPENGL_LIBRARY} | ||
${FREETYPE_LIBRARIES} | ||
${MATH_LIBRARY} | ||
- ${GLEW_LIBRARY} | ||
+ GLEW::GLEW | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typical patch which will breaks users 💣 |
||
) | ||
|
||
if(freetype-gl_BUILD_MAKEFONT) | ||
@@ -207,7 +207,7 @@ if(freetype-gl_BUILD_MAKEFONT) | ||
${OPENGL_LIBRARY} | ||
${FREETYPE_LIBRARIES} | ||
${MATH_LIBRARY} | ||
- ${GLEW_LIBRARY} | ||
+ GLEW::GLEW | ||
) | ||
|
||
if(MSVC AND NOT (MSVC_VERSION LESS 1900)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
diff --git a/build/cmake/CMakeLists.txt b/build/cmake/CMakeLists.txt | ||
index 25fb90b..68b977d 100644 | ||
--- a/build/cmake/CMakeLists.txt | ||
+++ b/build/cmake/CMakeLists.txt | ||
@@ -155,6 +155,7 @@ if(CMAKE_VERSION VERSION_LESS 2.8.12) | ||
else() | ||
target_compile_definitions(glew_s INTERFACE "GLEW_STATIC") | ||
foreach(t glew glew_s) | ||
+ target_compile_definitions(${t} PUBLIC $<INSTALL_INTERFACE:GLEW_NO_GLU>) | ||
target_include_directories(${t} PUBLIC $<INSTALL_INTERFACE:include>) | ||
endforeach() | ||
set(MAYBE_EXPORT EXPORT glew-targets) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nobody wants to remove CUDA from COLMAP. (Or back to 🧮?)