Reject import assert in parser, remove checker assert/with distinction
#2775
+1,225
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error at parse time when 'assert' keyword is used for import attributes (in all 3 parse locations: tryParseImportAttributes, parseExportDeclaration, parseImportType). Remove checker logic that distinguished between 'assert' and 'with' tokens, always using 'import attributes' messages. Co-authored-by: jakebailey <[email protected]>
Copilot
AI
changed the title
[WIP] Fix parsing errors by rejecting input entirely
Reject Feb 12, 2026
import assert in parser, remove checker assert/with distinction
jakebailey
reviewed
Feb 13, 2026
Comment on lines
+5
to
+8
| +/index.ts(2,23): error TS2880: Import assertions have been replaced by import attributes. Use 'with' instead of 'assert'. | ||
| +/index.ts(3,23): error TS2880: Import assertions have been replaced by import attributes. Use 'with' instead of 'assert'. | ||
| +/index.ts(5,50): error TS2880: Import assertions have been replaced by import attributes. Use 'with' instead of 'assert'. | ||
| +/index.ts(6,50): error TS2880: Import assertions have been replaced by import attributes. Use 'with' instead of 'assert'. |
Member
There was a problem hiding this comment.
Uh oh, we forgot to deprecate assert on import().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports microsoft/TypeScript#63077, but instead of a checker-level deprecation (suppressible via
ignoreDeprecations), we rejectassertat parse time unconditionally.Parser (
internal/parser/parser.go)assertkeyword is encountered in all three import attribute parse sites:tryParseImportAttributes,parseExportDeclaration,parseImportTypeChecker (
internal/checker/checker.go)isImportAttributesbranching incheckImportAttributes— always use "import attributes" diagnosticscore.IfElseingetResolutionModeOverride— always use "import attributes" messagesSince
grammarErrorOnNodeis a no-op when parse diagnostics exist, files usingassertnaturally skip redundant checker grammar errors.Baseline changes
importAssertionsDeprecated.errors.txt.diffdeleted (output now matches TS)importAssertionsDeprecatedIgnored(we error unconditionally; TS suppresses viaignoreDeprecations) and import type node cases (TS only checks import/export declarations in the checker)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.