Fix hangdump not working under dotnet test with .NET 10 SDK #6968
+35
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Youssef1313 <[email protected]>
Copilot
AI
changed the title
[WIP] Add test for hangdump in dotnet test
Add tests demonstrating HangDump is disabled under Nov 21, 2025
dotnet test
Copilot finished work on behalf of
Youssef1313
November 21, 2025 13:26
Youssef1313
reviewed
Nov 21, 2025
Member
Youssef1313
left a comment
Youssef1313
left a comment
There was a problem hiding this comment.
@copilot This needs to be an integration acceptance test, not unit test.
…angdump Co-authored-by: Youssef1313 <[email protected]>
Contributor
Author
Copilot
AI
changed the title
Add tests demonstrating HangDump is disabled under
Add integration acceptance test demonstrating HangDump is disabled under Nov 21, 2025
dotnet testdotnet test
Copilot finished work on behalf of
Youssef1313
November 21, 2025 15:29
Member
|
Confirmed test is failing: |
Youssef1313
changed the title
dotnet test
Youssef1313
approved these changes
Nov 21, 2025
Evangelink
reviewed
Nov 22, 2025
| [TestMethod] | ||
| public async Task HangDump_WithDotnetTest_CreateDump() | ||
| { | ||
| if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX)) |
Member
There was a problem hiding this comment.
Nit: we can use the oscondition attribute here instead
| _clock = clock; | ||
| if (_commandLineOptions.IsOptionSet(HangDumpCommandLineProvider.HangDumpOptionName) && | ||
| !_commandLineOptions.IsOptionSet(PlatformCommandLineProvider.ServerOptionKey)) | ||
| if (_commandLineOptions.IsOptionSet(HangDumpCommandLineProvider.HangDumpOptionName)) |
Member
There was a problem hiding this comment.
The description mentions checking both server and pipe cli options but the 2 parts of the implementation don't do that. Is this expected?
Member
There was a problem hiding this comment.
I don't think it's worth any special casing here at all. Even if this ended up being used in Test Explorer and it doesn't work, I don't think it's a big concern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HangDump extension is currently broken under
dotnet testbecauseIsEnabledAsync()checks!IsOptionSet(ServerOptionKey), which returns false when--serveris set (as it is withdotnet test).Test Added
Added an integration acceptance test
HangDump_WithDotnetTest_CreateDumptoMicrosoft.Testing.Platform.Acceptance.IntegrationTests/HangDumpTests.csthat demonstrates the bug.The test:
dotnet testwith hangdump options passed after the--separatordotnet testdotnet test(demonstrating the bug)Test Command
Current Broken Logic
Expected Pattern
Should match
RetryOrchestratorpattern to supportdotnet test:This differentiates between generic server mode (disabled) and
dotnet testmode (enabled).Note: Per issue instructions, only a test was added to demonstrate the bug. Production code changes require separate PR.
Original prompt
<issue_description>I think this is currently broken and the hangdump extension is never enabled under
dotnet test.testfx/src/Platform/Microsoft.Testing.Extensions.HangDump/HangDumpActivityIndicator.cs
Lines 85 to 86 in dacc39f
</issue_description>
<agent_instructions>Do not change production code. Only attempt to add a test.</agent_instructions>
Comments on the Issue (you are @copilot in this section)
@Youssef1313 Note: there is another use of `IsOptionSet(ServerOptionKey)` in the constructor. @Youssef1313 We have similar usage in `HangDumpEnvironmentVariableProvider` @Youssef1313 We should probably use `_commandLineOptions.IsOptionSet(PlatformCommandLineProvider.ServerOptionKey) && !_commandLineOptions.IsOptionSet(PlatformCommandLineProvider.DotNetTestPipeOptionKey)` instead. Or, alternatively, rely on the actual value of `--server` (for dotnet test, it's `dotnettestcli`), similar to what we do in TestHostBuilder:Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.