Codefix for MSTEST0023

[AtolagbeMuiz]

This PR fixes #6585

This Implementation is to modify the DoNotNegateBoolean Analyzer code for to suggest better and cleaner code when developers negate boolean arguments.

For example;

When a code is wrriten as Assert.IsTrue(!condition) , then the Analyzer would suggest Assert.IsFalse(condition)

Assert.IsFalse(!condition) Analyzer would suggest Assert.IsTrue(condition).

other edge cases were also considered, for example;
Assert.IsTrue(!(a && b)) Analyzer would suggest Assert.IsFalse(a && b)

Assert.IsFalse(!(x == y)), Analyzer would suggest Assert.IsTrue(x == y)

Assert.IsTrue(!!condition) Analyzer would suggest Assert.IsFalse(condition)

[Copilot]

Pull Request Overview

This PR implements a code fix for analyzer MSTEST0023, which suggests using the appropriate Assert method instead of negating boolean expressions in test assertions. For example, Assert.IsTrue(!condition) is replaced with Assert.IsFalse(condition).

Key Changes:

• Adds a new code fix provider DoNotNegateBooleanAssertionFixer that automatically corrects negated boolean assertions
• Updates the analyzer to include diagnostic properties that guide the code fix
• Adds comprehensive test coverage for various negation scenarios including simple negations, double negations, complex expressions, and method calls

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/Analyzers/MSTest.Analyzers.CodeFixes/DoNotNegateBooleanAssertionFixer.cs	New code fix provider that removes negations and swaps Assert.IsTrue/IsFalse methods
src/Analyzers/MSTest.Analyzers/DoNotNegateBooleanAssertionAnalyzer.cs	Updated analyzer to include proper assert method name in diagnostic properties
src/Analyzers/MSTest.Analyzers/Resources.resx	Added localization strings for code fix titles
src/Analyzers/MSTest.Analyzers/xlf/Resources.*.xlf	Added localization entries for all supported languages
test/UnitTests/MSTest.Analyzers.UnitTests/DoNotNegateBooleanAssertionAnalyzerTests.cs	Added comprehensive test cases for code fix functionality

[Evangelink]

Let's replace all calls to VerifyAnalyzerAsync from existing tests please

[AtolagbeMuiz]

Let's replace all calls to VerifyAnalyzerAsync from existing tests please

you want me to replace all VerifyAnalyzerAsync from the test with VerifyCodeFixAsync ?... is this just for pre-exisitng test cases which are just two.. or including the test cases I wrote? @Evangelink

[Evangelink]

Ideally everything should always use the code fix verifier API. This helps with ensuring we test as many cases as possible.

[AtolagbeMuiz]

Ideally everything should always use the code fix verifier API. This helps with ensuring we test as many cases as possible.

All the test cases has been updated to use VerifyCodeFixAsync @Evangelink .. pull request has been updated as well

[Evangelink]

We have had a few issues with trivias on our code fixers, I'd be great to add a few tests like:

Assert.IsTrue(!false,
    "some explanation");

Assert.IsTrue(/* some comment */ !false /* some other comment */);

[Evangelink]

I think this is unused and can be removed.

[Evangelink]

I think this test case can be dropped as it's already covered above.

[Evangelink]

Same remark for this test case.

[Copilot]

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

[Copilot]

The GetFixAllProvider method returns WellKnownFixAllProviders.BatchFixer, but there's a complete FixAll class implementation (lines 235-367) that is never used. Either the method should return new FixAll() to use the custom implementation, or the unused FixAll class should be removed if BatchFixer is sufficient for this scenario.

[Copilot]

Use a using directive for System.Globalization instead of fully qualifying CultureInfo.InvariantCulture. This aligns with the coding guidelines that prefer using directives and is consistent with other code fixers in the codebase.

[Copilot]

The entire FixAll class (lines 235-367) is defined but never instantiated or used since GetFixAllProvider() returns WellKnownFixAllProviders.BatchFixer. This adds 133 lines of dead code. Remove this class unless you intend to use it by changing GetFixAllProvider() to return new FixAll().