Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add analyzer for value type usage with Assert.AreSame #4493

Merged
merged 5 commits into from
Jan 4, 2025
Merged

Add analyzer for value type usage with Assert.AreSame #4493

merged 5 commits into from
Jan 4, 2025

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jan 2, 2025 •
edited
Loading

Fixes #4352

Evangelink
Evangelink previously approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would still add a rule description explaining why this is never working.

src/Analyzers/MSTest.Analyzers/AvoidAssertAreSameWithValueTypesAnalyzer.cs Outdated Show resolved Hide resolved
src/Analyzers/MSTest.Analyzers/AvoidAssertAreSameWithValueTypesAnalyzer.cs Show resolved Hide resolved
@Evangelink Evangelink enabled auto-merge (squash) January 4, 2025 09:41
@Evangelink Evangelink merged commit 0b65aa2 into microsoft:main Jan 4, 2025
11 checks passed
@Youssef1313 Youssef1313 deleted the aresame-valuetypes-analyzer branch January 4, 2025 11:11
This was referenced Jan 4, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
Area: Analyzers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve handling of incorrect calls to Assert.AreSame
2 participants
@Youssef1313 @Evangelink