Implement analyzer and codefix to switch to Assert.ThrowsExactly[Async] #4459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Dec 27, 2024
| } | ||
|
|
||
| [TestMethod] | ||
| public async Task WhenAssertThrowsExceptionFuncOverloadComplexBody_Diagnostic() |
There was a problem hiding this comment.
I hope no one is calling Assert.ThrowsException this way 😄
There was a problem hiding this comment.
Copilot reviewed 20 out of 36 changed files in this pull request and generated no comments.
Files not reviewed (16)
- src/Analyzers/MSTest.Analyzers.CodeFixes/CodeFixResources.Designer.cs: Language not supported
- src/Analyzers/MSTest.Analyzers.CodeFixes/CodeFixResources.resx: Language not supported
- src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.cs.xlf: Language not supported
- src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.de.xlf: Language not supported
- src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.es.xlf: Language not supported
- src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.fr.xlf: Language not supported
- src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.it.xlf: Language not supported
- src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.ja.xlf: Language not supported
- src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.ko.xlf: Language not supported
- src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.pl.xlf: Language not supported
- src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.pt-BR.xlf: Language not supported
- src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.ru.xlf: Language not supported
- src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.tr.xlf: Language not supported
- src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.zh-Hans.xlf: Language not supported
- src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.zh-Hant.xlf: Language not supported
- src/Analyzers/MSTest.Analyzers/Resources.Designer.cs: Language not supported
Evangelink
previously approved these changes
Dec 31, 2024
src/Analyzers/MSTest.Analyzers.CodeFixes/UseNewerAssertThrowsFixer.cs
Outdated
Show resolved
Hide resolved
| @@ -543,4 +543,10 @@ The type declaring these methods should also respect the following rules: | |||
| <data name="DynamicDataShouldBeValidMessageFormat_SourceTypeNotPropertyOrMethod" xml:space="preserve"> | |||
| <value>'[DynamicData]' member '{0}.{1}' is not a property nor a method. Only properties and methods are supported.</value> | |||
| </data> | |||
| </root> | |||
| <data name="UseNewerAssertThrowsTitle" xml:space="preserve"> | |||
| <value>Use newer methods to assert exceptions</value> | |||
There was a problem hiding this comment.
I don't recall, do we see title on the menu or message?
There was a problem hiding this comment.
I think the message. Not sure of all places that show the title, but Solution Explorer is one that shows the title (when you expand Dependencies -> Analyzers)
Comment on lines
+114
to
+116
| // NOTE: The discard is needed to avoid CS0201: Only assignment, call, increment, decrement, and new object expressions can be used as a statement | ||
| // This is because ThrowsException has a Func<object> overload that is being used in the original code. | ||
| // But ThrowsExactly only has an Action overload. |
There was a problem hiding this comment.
Interesting, I'll try to have a look at this specific API and see if there is any need to have it on the newer APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4257