Remove tests for experimental jemalloc ABIs #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 5680cf6dc6e2 ("jemalloc: don't expose 3.0 compat symbols") in
FreeBSD src removes the default symbols for allocm() and friends, so
this test no longer links. Compatibility is stil provided for programs
linking against FBSD_1.3, but here it seems easier to simply stop
referencing them.
|
@davidchisnall you added these bits are you okay with them going away now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed in order to build snmalloc's tests on recent FreeBSD main.
I verified that all of the remaining tests pass there.