-
Notifications
You must be signed in to change notification settings - Fork 75
Keyvault for secrets #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Development
Are you sure you want to change the base?
Keyvault for secrets #492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds Azure Key Vault support for storing agent and plugin secrets, introduces dynamic UI for plugin additional settings driven by JSON Schemas, and various loader/refactor updates to support the new features.
- Key Vault helpers for storing/retrieving/deleting secrets across agents and plugins
- Dynamic plugin Additional Fields UI (schema-driven) and schema updates
- Admin UI: Security tab with Key Vault test; loader changes to resolve Key Vault references at runtime
Reviewed Changes
Copilot reviewed 48 out of 49 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| deployers/New-CosmosContainerDynamicRUs.ps1 | Script to migrate/update Cosmos containers to autoscale with a given max RU |
| application/single_app/templates/admin_settings.html | Adds Security tab for Key Vault settings and test button |
| application/single_app/templates/_sidebar_nav.html | Adds Security menu and updates Agents label |
| application/single_app/templates/_plugin_modal.html | Prepares inputs for dynamic auth fields and adds container for dynamic Additional Fields |
| application/single_app/static/json/schemas/* | Adds/updates plugin and additional settings schemas; base plugin schema expanded |
| application/single_app/static/js/workspace/workspace_plugins.js | Improves save flow UX and error display |
| application/single_app/static/js/validatePlugin.mjs | Updates compiled validator for expanded auth types and rules |
| application/single_app/static/js/plugin_modal_stepper.js | Major: dynamic Additional Fields UI builder/collector; auth field toggling; summary updates |
| application/single_app/static/js/agent_modal_stepper.js | Save button UX improvements |
| application/single_app/static/js/admin/admin_settings.js | Adds Key Vault connection test handler |
| application/single_app/semantic_kernel_plugins/* | New UI test plugin; queue storage plugin fix; logged loader changes |
| application/single_app/semantic_kernel_loader.py | Resolves Key Vault secrets at load time; various loader improvements |
| application/single_app/route_* | Routes updated to support/test Key Vault and new flows |
| application/single_app/functions_* | New Key Vault helpers; global/personal actions/agents updated to use KV; settings defaults added |
| application/single_app/requirements.txt | Adds azure-keyvault-secrets |
| .github/* | Workflow and repo instruction updates |
Comments suppressed due to low confidence (1)
application/single_app/functions_keyvault.py:1
- logging.warn is deprecated; use logging.warning instead.
# functions_keyvault.py
Updates with keyvault helpers to allow saving secrets for agents and plugins to an azure keyvault.
Adds a dynamic UI for additional settings and fallback json support.
Various other code improvements to facilitate the above two features.