Skip to content

Implement writingDirection property for Text in Fabric renderer #14764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 9 commits into from

Add text layout invalidation for baseWritingDirection property changes

92676a0
Select commit
Loading
Failed to load commit list.
Closed

Implement writingDirection property for Text in Fabric renderer #14764

Add text layout invalidation for baseWritingDirection property changes
92676a0
Select commit
Loading
Failed to load commit list.
Azure Pipelines / Secure PR failed Jun 16, 2025 in 44m 38s

Build #RNW_0.0.0-canary.965.pr621883 failed

25 errors / 3 warnings

Details

Tests

  • Failed: 0 (0.00%)
  • Passed: 424 (100.00%)
  • Other: 0 (0.00%)
  • Total: 424
Code coverage

  • 3205 of 3780 blocks covered (84.79%)
  • 2932 of 3277 lines covered (89.47%)

Annotations

Check failure on line 61 in vnext\Microsoft.ReactNative\Fabric\platform\react\renderer\textlayoutmanager\WindowsTextLayoutManager.h

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Secure PR

vnext\Microsoft.ReactNative\Fabric\platform\react\renderer\textlayoutmanager\WindowsTextLayoutManager.h#L61 

vnext\Microsoft.ReactNative\Fabric\platform\react\renderer\textlayoutmanager\WindowsTextLayoutManager.h(61,35): Error C3646: 'GetNaturalReadingDirection': unknown override specifier

Check failure on line 61 in vnext\Microsoft.ReactNative\Fabric\platform\react\renderer\textlayoutmanager\WindowsTextLayoutManager.h

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Secure PR

vnext\Microsoft.ReactNative\Fabric\platform\react\renderer\textlayoutmanager\WindowsTextLayoutManager.h#L61 

vnext\Microsoft.ReactNative\Fabric\platform\react\renderer\textlayoutmanager\WindowsTextLayoutManager.h(61,62): Error C2059: syntax error: 'const'

Check failure on line 61 in vnext\Microsoft.ReactNative\Fabric\platform\react\renderer\textlayoutmanager\WindowsTextLayoutManager.h

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Secure PR

vnext\Microsoft.ReactNative\Fabric\platform\react\renderer\textlayoutmanager\WindowsTextLayoutManager.h#L61 

vnext\Microsoft.ReactNative\Fabric\platform\react\renderer\textlayoutmanager\WindowsTextLayoutManager.h(61,118): Error C2238: unexpected token(s) preceding ';'

Check failure on line 8827 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Secure PR

Build log #L8827 

Process 'msbuild.exe' exited with code '1'.
View more details on Azure Pipelines