Skip to content

fix: declare support for 0.77 #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tido64 merged 1 commit into from
Jan 8, 2025
Merged

fix: declare support for 0.77 #2340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions android/app/src/main/jni/TurboModuleManagerDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,8 @@ namespace ReactTestApp
: public facebook::jni::HybridClass<TurboModuleManagerDelegate,
facebook::react::TurboModuleManagerDelegate>
{
// Signatures changed in 0.70 to avoid unnecessary string copies; see
// https://github.com/facebook/react-native/commit/3337add547c60b84816ef5dad82f4ead2e8742ef
#if __has_include(<ReactCommon/CompositeTurboModuleManagerDelegate.h>)
using SharedCallInvoker = const std::shared_ptr<facebook::react::CallInvoker> &;
using StringRef = const std::string &;
#else
using SharedCallInvoker = const std::shared_ptr<facebook::react::CallInvoker>;
using StringRef = const std::string;
#endif

public:
static constexpr auto kJavaDescriptor =
Expand Down
2 changes: 1 addition & 1 deletion android/gradle-wrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const INT_MAX = 2 ** 31 - 1;
* @type {[number, [number, string], [number, string]][]}
*/
const GRADLE_VERSIONS = [
[v(0, 76, 0), [v(8, 10, 2), "8.10.2"], [INT_MAX, ""]], // 0.76: [8.10.2, *)
[v(0, 76, 0), [v(8, 11, 1), "8.11.1"], [INT_MAX, ""]], // 0.76: [8.11.1, *)
[v(0, 75, 0), [v(8, 8, 0), "8.8"], [v(8, 9, 0), "8.8"]], // 0.75: [8.8, 8.9)
[v(0, 74, 0), [v(8, 6, 0), "8.6"], [v(8, 9, 0), "8.8"]], // 0.74: [8.6, 8.9)
[v(0, 73, 0), [v(8, 3, 0), "8.3"], [v(8, 9, 0), "8.8"]], // 0.73: [8.3, 8.9)
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,10 @@
"uuid": "^11.0.0"
},
"peerDependencies": {
"@callstack/react-native-visionos": "0.73 - 0.76",
"@callstack/react-native-visionos": "0.73 - 0.77",
"@expo/config-plugins": ">=5.0",
"react": "18.1 - 19.0",
"react-native": "0.70 - 0.76 || >=0.77.0-0 <0.77.0",
"react-native": "0.70 - 0.77 || >=0.78.0-0 <0.78.0",
"react-native-macos": "^0.0.0-0 || 0.71 - 0.76",
"react-native-windows": "^0.0.0-0 || 0.70 - 0.76"
},
Expand Down
4 changes: 2 additions & 2 deletions test/android/gradle-wrapper.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ describe("configureGradleWrapper()", () => {
process.argv.push("run-android");

const cases = [
["8.9", "0.76.0", "gradle-8.10.2-bin.zip"],
["8.9", "0.76.0", "gradle-8.11.1-bin.zip"],
["8.9", "0.75.0", "gradle-8.8-bin.zip"],
["8.7", "0.75.0", "gradle-8.8-bin.zip"],
["8.9", "0.74.0", "gradle-8.8-bin.zip"],
Expand Down Expand Up @@ -190,7 +190,7 @@ describe("configureGradleWrapper()", () => {
process.argv.push("run-android");

const cases = [
["8.10.2", "0.76.0"],
["8.11.1", "0.76.0"],
["8.8", "0.75.0"],
["8.8", "0.74.0"],
["8.8", "0.73.0"],
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12043,10 +12043,10 @@ __metadata:
typescript: "npm:^5.0.0"
uuid: "npm:^11.0.0"
peerDependencies:
"@callstack/react-native-visionos": 0.73 - 0.76
"@callstack/react-native-visionos": 0.73 - 0.77
"@expo/config-plugins": ">=5.0"
react: 18.1 - 19.0
react-native: 0.70 - 0.76 || >=0.77.0-0 <0.77.0
react-native: 0.70 - 0.77 || >=0.78.0-0 <0.78.0
react-native-macos: ^0.0.0-0 || 0.71 - 0.76
react-native-windows: ^0.0.0-0 || 0.70 - 0.76
peerDependenciesMeta:
Expand Down
Loading