Skip to content

fix(android): dynamic CLI resolution based on current version #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tido64 merged 1 commit into from
Nov 16, 2024
Merged

fix(android): dynamic CLI resolution based on current version #2315

tido64 merged 1 commit into from
Nov 16, 2024

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Nov 15, 2024

Description

Use @rnx-kit/tools-react-native to correctly resolve @react-native-community/cli to load the project config.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

cd example
yarn android

# In a separate terminal
yarn start

Screenshots

Screenshot_1731670996

@tido64 tido64 requested a review from Saadnajmi November 15, 2024 15:19
@tido64 tido64 requested a review from JasonVMo as a code owner November 15, 2024 15:19
@github-actions github-actions bot added the platform: Android This affects Android label Nov 15, 2024
@tido64 tido64 merged commit 304617c into trunk Nov 16, 2024
30 checks passed
@tido64 tido64 deleted the tido/android/fix-autolinking-cli branch November 16, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees

No one assigned

Labels

platform: Android This affects Android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tido64 @Saadnajmi