Refactor nlp_engine_provider.py to improve configuration handling and… #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… missing config file
… improving error messages for missing fields
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SharonHart
reviewed
Mar 31, 2025
SharonHart
reviewed
Mar 31, 2025
presidio-analyzer/presidio_analyzer/nlp_engine/nlp_engine_provider.py
Outdated
Show resolved
Hide resolved
omri374
reviewed
Apr 3, 2025
presidio-analyzer/presidio_analyzer/nlp_engine/nlp_engine_provider.py
Outdated
Show resolved
Hide resolved
…rosoft/presidio into fix-1556-config-file-missing
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SharonHart
previously approved these changes
Apr 22, 2025
omri374
reviewed
Apr 22, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…-1556-config-file-missing
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@omri374 |
|
@omri374 @SharonHart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error Reporting #1556
In this update, we have:
FileNotFoundErroris raised rather than silently defaulting.default.yaml), if it’s missing we now log a warning and fall back to an internal built-in default.Change Description
Describe your changes here, for example:
_read_nlp_confto raise an exception when a user-provided config file does not exist.FileNotFoundErrorfor the default config file and use a built-in configuration if it’s missing.Issue Reference
This PR fixes issue #XX
Checklist