chore: move timeout handling to the client #35988
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results for "tests 1"6 failed 7 flaky39226 passed, 804 skipped Merge workflow run. |
Test results for "tests 2"12 failed 145 flaky239469 passed, 9341 skipped Merge workflow run. |
yury-s
reviewed
May 19, 2025
| @@ -1611,7 +1590,7 @@ Page: | |||
| goBack: | |||
| title: Go back | |||
| parameters: | |||
| timeout: number? | |||
| timeout: number | |||
There was a problem hiding this comment.
I'm a little worried that it's very easy to break in the ports without noticing. Maybe we can store per-client default timeouts on the server end?
| @@ -90,6 +90,7 @@ export class BrowserContext extends ChannelOwner<channels.BrowserContextChannel> | |||
| this._isChromium = this._browser?._name === 'chromium'; | |||
| this.tracing = Tracing.from(initializer.tracing); | |||
| this.request = APIRequestContext.from(initializer.requestContext); | |||
| this.request._timeoutSettings = this._timeoutSettings; | |||
There was a problem hiding this comment.
Every client will have to do the same thing in every lang. I think we should consider changing this settings to be per client on the server end.
| @@ -344,7 +331,7 @@ export class AndroidDevice extends SdkObject { | |||
| proxy: options.proxy, | |||
| protocolLogger: helper.debugProtocolLogger(), | |||
| browserLogsCollector: new RecentLogsCollector(), | |||
| originalLaunchOptions: {}, | |||
| originalLaunchOptions: { timeout: 0 }, | |||
| } | ||
| throw new Error('ElementHandle belongs to unexpected scope'); | ||
| const parentScope = this.parentScope().parentScope(); | ||
| if (parentScope instanceof BrowserContextDispatcher) |
There was a problem hiding this comment.
But this is a change from
const scope = this.parentScope();
if (scope instanceof BrowserContextDispatcher)
return scope;
yury-s
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #35987.