Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a Dependabot Security alert and updates formidable to the latest version.
The reason for this
disableRequestBodyConsumption
logic is that our TestServer reads the request body in_onRequest
but theformidable
library attaches the'data'
handlers too late afterawait this.writeHeaders
- this causes that the TestServer is consuming formidable's'data'
events.One alternative which I considered is making
onRequest
async, awaiting thehandler.call(null, request, response);
call and attaching the'data'
request handlers afterwards. This seems to work in a local experiment.Another alternative is changing
postBody
to a function which does the same what its doing right now but adds the'data'
event listeners when its called and requires the callee to run it inside asetRoute
callback so the request is not done/ended yet. I think that is a viable solution as well.Resolves #35823
Closes #35797