disk_nvme: add specific test for DMA allocation failure handling #2206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkur
requested review from
a team,
amy-microsoft,
Copilot and
gurasinghMS
and removed request for
Copilot
gurasinghMS
reviewed
Oct 18, 2025
gurasinghMS
reviewed
Oct 18, 2025
gurasinghMS
reviewed
Oct 18, 2025
gurasinghMS
reviewed
Oct 18, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive testing for DMA allocation failure handling in the NVMe driver to ensure the driver gracefully handles allocation failures during both initial driver creation and secondary IO issuer creation.
Key Changes:
- Introduced a customizable
DeviceTestDmaClientthat allows tests to inject allocation failures through callback hooks - Added two new test cases: one verifying driver creation fails when DMA allocation fails, and another verifying the driver falls back to bounce buffers when secondary IO issuer allocation fails
- Refactored existing NVMe driver tests to use a unified configuration structure
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| vm/devices/user_driver_emulated_mock/src/lib.rs | Adds DeviceTestDmaClient with callback hooks for customizing DMA allocation behavior in tests |
| vm/devices/storage/disk_nvme/nvme_driver/src/tests.rs | Adds two allocation failure tests and refactors existing tests to use configuration structure |
| vm/devices/storage/disk_nvme/nvme_driver/Cargo.toml | Adds page_pool_alloc dependency needed for test DMA client implementation |
gurasinghMS
approved these changes
Oct 20, 2025
| /// Called when the DMA client needs to attach pending buffers. | ||
| fn attach_pending_buffers( | ||
| &self, | ||
| inner: &PagePoolAllocator, |
There was a problem hiding this comment.
nit: why the different name for the same type?
axelandrejs
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test to ensure that the NVMe driver correctly handles allocation failures (they should
be non-fatal to secondary IO issuer create).