firmware_uefi: EFI Diagnostics filtering

[maheeraeron]

This PR adds logic to filter logs for EFI diagnostics. By default, the logs will still default to show only ERROR and WARNING. This change must come first before the next UEFI update to preserve all logs to the in-memory buffer.

I will add some output soon to show what the inspect output looks like when you query for the LogLevel

[Copilot]

Pull Request Overview

This PR implements filtering functionality for EFI diagnostics logs in firmware_uefi. The changes add a configurable log level parameter that defaults to ERROR and WARN only, but can be expanded to include INFO or all log levels, ensuring the in-memory buffer preserves all logs while controlling what gets processed.

Key Changes:

• Introduces a new LogLevel type with three configuration options: Default (ERROR/WARN), Info (ERROR/WARN/INFO), and Full (all levels)
• Threads the log level configuration through the entire stack from CLI arguments to the UEFI firmware device
• Updates the diagnostics processor to filter logs based on the configured level

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
vm/devices/get/guest_emulation_transport/src/client.rs	Adds efi_diagnostics_log_level field to JSON deserialization
vm/devices/get/guest_emulation_transport/src/api.rs	Imports EfiDiagnosticsLogLevelType and adds field to platform settings
vm/devices/get/guest_emulation_device/src/test_utilities.rs	Sets default log level in test utilities
vm/devices/get/guest_emulation_device/src/resolver.rs	Converts between resource and protocol log level types
vm/devices/get/guest_emulation_device/src/lib.rs	Adds log level to GuestConfig and passes it through device platform settings
vm/devices/get/get_resources/src/lib.rs	Defines EfiDiagnosticsLogLevelType enum in resources
vm/devices/get/get_protocol/src/dps_json.rs	Defines EfiDiagnosticsLogLevelType for JSON protocol
vm/devices/firmware/firmware_uefi/src/service/diagnostics/processor.rs	Updates processing logic to filter logs based on configured level
vm/devices/firmware/firmware_uefi/src/service/diagnostics/mod.rs	Implements LogLevel wrapper type with filtering logic and inspect support
vm/devices/firmware/firmware_uefi/src/lib.rs	Exports LogLevel and adds it to UefiConfig
petri/src/vm/openvmm/construct.rs	Uses default log level in test configurations
openvmm/openvmm_entry/src/ttrpc/mod.rs	Sets default log level in ttrpc configuration
openvmm/openvmm_entry/src/lib.rs	Converts CLI arguments to log level configuration
openvmm/openvmm_entry/src/cli_args.rs	Adds CLI argument for EFI diagnostics log level
openvmm/hvlite_defs/src/config.rs	Defines EfiDiagnosticsLogLevelType in config definitions
openvmm/hvlite_core/src/worker/dispatch.rs	Converts config log level to firmware LogLevel
openhcl/underhill_core/src/worker.rs	Maps protocol log level to firmware LogLevel

[smalis-msft]

Do these need numbers?

[maheeraeron]

Perhaps not, although the corresponding mars file on the host did so I thought we'd at least be consistent. They are in the same order anyway, should I remove them?

[smalis-msft]

Yeah, if we're not actually relying on them in any way we shouldn't have them.

[maheeraeron]

Hmm... just tested with OpenHCL on Hyper-V now but changing the WMI property is not getting picked up properly:

[maheeraeron]

not a fan of this syntax... should i just use regular if-statements instead...?

[github-actions]

At least one Petri test failed.

[github-actions]

At least one Petri test failed.