Skip to content

Conversation

@ishwar-raut1
Copy link
Contributor

Description

Small change to remove the MS Domain check on onnx model nodes

Motivation and Context

The check returns unsupported for some nodes having an MS Domain. Trt RTX supports some MS domain ops. if return unsupported these ops falls back to CPU EP

@ankan-ban @chilo-ms @gedoensmax @jywu-msft

@ankan-ban
Copy link
Contributor

looks good (we plan to support some of the common contrib ops in the EP - especially for LLM support)

@gedoensmax
Copy link
Contributor

How "silent" does our parser do the plitting ? We should make sure that during supportsModel no error log is omitted. This is why the change was introduced since a support check should not log errors during checking in my opinion.

@jywu-msft jywu-msft requested a review from chilo-ms May 20, 2025 15:03
@chilo-ms
Copy link
Contributor

/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@chilo-ms
Copy link
Contributor

chilo-ms commented May 20, 2025

How "silent" does our parser do the plitting ? We should make sure that during supportsModel no error log is omitted. This is why the change was introduced since a support check should not log errors during checking in my opinion.

I don't remember in the past i saw error being omitted and forces program to exit when TRT parser encounters unsupported ops, it did log/print some info though.
Anyway, it's better to check the parser.

@chilo-ms chilo-ms merged commit 4f208b3 into microsoft:main May 21, 2025
82 checks passed
@ishwar-raut1 ishwar-raut1 deleted the iraut/FixDomainCheck branch July 30, 2025 11:34
quic-ankus pushed a commit to CodeLinaro/onnxruntime that referenced this pull request Nov 25, 2025
### Description
<!-- Describe your changes. -->
Small change to remove the MS Domain check on onnx model nodes


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
The check returns unsupported for some nodes having an MS Domain. Trt
RTX supports some MS domain ops. if return unsupported these ops falls
back to CPU EP

@ankan-ban @chilo-ms @gedoensmax @jywu-msft

Co-authored-by: iraut <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants