Skip to content

Include test toolkit in cached image when toolkit flags are set #4144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffreybulanadi wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

Include test toolkit in cached image when toolkit flags are set #4144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion AppHandling/Run-AlPipeline.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
.Parameter imageName
If imageName is specified it will be used to build an image, which serves as a cache for faster container generation.
Only specify imageName if you are going to create multiple containers from the same artifacts.
If installTestRunner, installTestFramework, installTestLibraries, or installPerformanceToolkit are also specified,
the test toolkit will be baked into the image so it does not have to be imported on every container creation.
.Parameter enableTaskScheduler
Include this switch if the Task Scheduler should be running inside the build/test container, as some app features rely on the Task Scheduler.
.Parameter assignPremiumPlan
Expand Down Expand Up @@ -735,7 +737,20 @@ function GetBuildContainer {
"FilesOnly" = $filesOnly
}

if ($imageName) { $Parameters += @{ "imageName" = $imageName } }
if ($imageName) {
$Parameters += @{ "imageName" = $imageName }
# When an imageName is specified and test toolkit installation is requested, include
# the test toolkit in the image build so it does not have to be imported on every
# container creation. This matches the logic in Import-TestToolkitToBcContainer.
if ($installTestRunner -or $installTestFramework -or $installTestLibraries -or $installPerformanceToolkit) {
$Parameters += @{
"includeTestToolkit" = $true
"includeTestLibrariesOnly" = [bool]$installTestLibraries
"includeTestFrameworkOnly" = !$installTestLibraries -and [bool]($installTestFramework -or $installPerformanceToolkit)
"includePerformanceToolkit" = [bool]$installPerformanceToolkit
}
}
}
if ($memoryLimit) { $Parameters += @{ "memoryLimit" = $memoryLimit } }

$Parameters += @{
Expand Down