-
Notifications
You must be signed in to change notification settings - Fork 52
[0052] Experimental DXIL Ops #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
damyanp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great write up, thanks!
I've left some editorial comments and one thing that might be good to expand on, but other than that this looks like it's in pretty good shape to merge.
Co-authored-by: Tex Riddell <[email protected]>
llvm-beanz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment inline. I think my big concern is how much of this is DXC-centric. Much of this document describes DXC infrastructure that doesn't exist in Clang.
Co-authored-by: Chris B <[email protected]>
Right, the proposal was written with a lot of consideration to "what makes sense for DXC today" which imo makes sense given that DXC has the more restrictive infrastructure. I'll make sure the PR presenting the proposed solution (coming soon) will discuss potential implementations for both DXC and Clang. I just want to be careful that the spec doesn't over prescribe the implementation. |
Proposal to discuss various options to enable experimental features for DXIL ops and HLSL intrinsics