[Lang] Update and restructure cbuffer spec #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change pulls the cbuffer section into the Declarations chapter instead of the Resources chapter since it defines a declaration type, and updates the grammar and specification language based on the updates to proposal 37. The updated language avoids nesting of cbuffers and namepaces in cbuffers to simplify semantic validation. The updated langauge also adds additional language around storage durations which is referenced in the updated specification language.
llvm-beanz
added a commit
that referenced
this pull request
Nov 6, 2025
This slightly scales back the proposal to restricting namespaces in cbuffers and restricting nesting of cbuffers. This is likely a safe change for HLSL 202x, and we'll consider more significant changes in subsequent language updates. This conclusion came out of the language design meeting discussion from 10/13/2025. The language spec updates are posted in a draft as #684. --------- Co-authored-by: Helena Kotas <[email protected]>
Icohedron
approved these changes
Nov 7, 2025
Collaborator
Icohedron
left a comment
Icohedron
left a comment
There was a problem hiding this comment.
Reads good to me! LGTM
hekota
approved these changes
Nov 11, 2025
Comment on lines
+182
to
+184
| \p Declarations within a cbuffer declaration that declare names, declare their | ||
| names in the scope containing the cbuffer declaration. The cbuffer declaration | ||
| itself does not declare a declaration scope. A cbuffer declaration may not |
Member
There was a problem hiding this comment.
Suggested change
| \p Declarations within a cbuffer declaration that declare names, declare their | |
| names in the scope containing the cbuffer declaration. The cbuffer declaration | |
| itself does not declare a declaration scope. A cbuffer declaration may not | |
| \p The cbuffer declaration itself does not declare a declaration scope. | |
| Declarations within a cbuffer declaration that declare names, declare their names | |
| in the scope containing the cbuffer declaration. A cbuffer declaration may not |
I think it would read better if the first two sentences are flipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change pulls the cbuffer section into the Declarations chapter instead of the Resources chapter since it defines a declaration type, and updates the grammar and specification language based on the updates to proposal 37.
The updated language avoids nesting of cbuffers and namepaces in cbuffers to simplify semantic validation. The updated langauge also adds additional language around storage durations which is referenced in the updated specification language.
Resolves #671