Skip to content

fix(react-charts): fix non-plottable points popover issue #35501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 21, 2025
+19 −4
Merged

fix(react-charts): fix non-plottable points popover issue #35501

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d320a91
fix popover issue
Nov 19, 2025
3e236eb
Add change file
Nov 19, 2025
ff475ef
resolve comments
Nov 21, 2025
0fcc5bc
remove state update
Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions packages/charts/react-charts/library/src/components/LineChart/LineChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1497,6 +1497,16 @@ export const LineChart: React.FunctionComponent<LineChartProps> = React.forwardR
: xPointToHighlight;
const found = findCalloutPoints(calloutPointsRef.current, xPointToHighlight) as CustomizedCalloutData | undefined;
const pointToHighlight: LineChartDataPoint = lineChartData![linenumber].data[index!] as LineChartDataPoint;

// Check if this point is plottable. If not, close the popover and return.
const xPoint = _xAxisScale(pointToHighlight.x);
const yPoint = yScale(pointToHighlight.y);
if (!isPlottable(xPoint, yPoint)) {
setPopoverOpen(false);
setActivePoint('');
return;
}

const pointToHighlightUpdated =
nearestCircleToHighlight === null ||
(nearestCircleToHighlight !== null &&
Expand All @@ -1507,14 +1517,14 @@ export const LineChart: React.FunctionComponent<LineChartProps> = React.forwardR
_uniqueCallOutID = `#${_staticHighlightCircle}_${linenumber}`;

d3Select(`#${_staticHighlightCircle}_${linenumber}`)
.attr('cx', `${_xAxisScale(pointToHighlight.x)}`)
.attr('cy', `${yScale(pointToHighlight.y)}`)
.attr('cx', `${xPoint}`)
.attr('cy', `${yPoint}`)
.attr('visibility', 'visibility');

d3Select(`#${_verticalLine}`)
.attr('transform', () => `translate(${_xAxisScale(pointToHighlight.x)}, ${yScale(pointToHighlight.y)})`)
.attr('transform', () => `translate(${xPoint}, ${yPoint})`)
.attr('visibility', 'visibility')
.attr('y2', `${lineHeight - 5 - yScale(pointToHighlight.y)}`);
.attr('y2', `${lineHeight - 5 - yPoint}`);

const targetElement = document.getElementById(`${_staticHighlightCircle}_${linenumber}`);
const rect = targetElement!.getBoundingClientRect();
Expand Down
Loading