fix(Sparkline): Apply width, height, and valueTextWidth props to component #35479
+104
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix hardcoded width, and height values that ignored custom values from props - Update useEffect dependencies to recalculate scales when dimensions change - Add comprehensive tests for dimension props functionality - Create SparklineDimensions story demonstrating customizable dimensions Fixes issue where Sparkline dimension props were defined but not functional
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jesspagan
force-pushed
the
fix/sparkline-dimension-props
branch
from
d74f060 to
e1c43ac
Compare
Contributor
Author
|
@AtishayMsft Thanks for the approval! Could you please merge this PR since I don't have merge permissions to the master branch? |
Contributor
|
@jesspagan Thanks for your contribution. This PR is merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Sparkline component had width, height, and valueTextWidth props defined in the SparklineProps type, but these props were not being used in the implementation.
Solution
Testing
Files Changed
Change File