-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore: migrate to jest v30 #35456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: migrate to jest v30 #35456
Conversation
| @@ -1,4 +1,4 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
| // Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
| "name": "Debug current open test", | ||
| "type": "node", | ||
| "request": "launch", | ||
| "program": "${workspaceRoot}/scripts/executors/src/debug-test.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-DonutChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 27057 | Changed |
vr-tests-react-components/Drawer 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Drawer.overlay drawer full - High Contrast.chromium.png | 4937 | Changed |
| vr-tests-react-components/Drawer.overlay drawer full - Dark Mode.chromium.png | 2653 | Changed |
| vr-tests-react-components/Drawer.overlay drawer full.chromium.png | 3295 | Changed |
| vr-tests-react-components/Drawer.overlay drawer full - RTL.chromium.png | 1161 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 12 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 497 | Changed |
vr-tests-web-components/Avatar 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Avatar. - Dark Mode.normal.chromium_1.png | 298 | Changed |
vr-tests-web-components/Badge 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png | 443 | Changed |
vr-tests-web-components/MenuList 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/MenuList. - RTL.normal.chromium_1.png | 39083 | Changed |
vr-tests-web-components/RadioGroup 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/RadioGroup. - Dark Mode.normal.chromium_1.png | 89 | Changed |
vr-tests-web-components/TextInput 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/TextInput. - Dark Mode.normal.chromium_1.png | 288 | Changed |
vr-tests/react-charting-MultiStackBarChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-MultiStackBarChart.Basic_Absolute.default.chromium.png | 359 | Changed |
| @@ -1115,7 +1115,7 @@ These are not production-ready components and **should never be used in product* | |||
| }; | |||
| } | |||
|
|
|||
| function getExecSpyCalls(spy: jest.SpyInstance) { | |||
| function getExecSpyCalls(spy: jest.Spied<typeof childProcess.execSync>) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0209151 to
ae7b442
Compare
| "cwd": "${fileDirname}", | ||
| "stopOnEntry": false, | ||
| "args": ["-i", "--testPathPattern=\\b${fileBasenameNoExtension}", "--watch"], | ||
| "args": ["-i", "--testPathPatterns=\\b${fileBasenameNoExtension}", "--watch"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a8c0ba6 to
5ad560b
Compare
| "through2": "4.0.2", | ||
| "tmp": "0.2.1", | ||
| "ts-jest": "29.2.5", | ||
| "ts-jest": "29.4.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog mentions jest v30 supported from 29.4.0
30d3191 to
6835410
Compare
6835410 to
a6fd5b3
Compare
Previous Behavior
jest 29
New Behavior
jest v30 announcement
migration guide
ES2015.Symbol.WellKnownas part of their lib. This is necessary because we don't use solution configs besides v9 and jest 30 types contain ES2015++ types. Without this build will failRelated Issue(s)