Add SQL performance option #4785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LTA-Thinking
added
Enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| if (inputResource is not Parameters) | ||
| { | ||
| throw new RequestNotValidException(string.Format(Resources.UnsupportedResourceType, inputResource.GetType().ToString())); | ||
| throw new RequestNotValidException(string.Format(Api.Resources.UnsupportedResourceType, inputResource.GetType().ToString())); |
Check notice
Code scanning / CodeQL
Redundant ToString() call Note
Comment on lines
+234
to
+258
| if (string.Equals(useQueryCache, "true", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| return await SearchImpl(sqlSearchOptions, true, cancellationToken); | ||
| } | ||
| else if (string.Equals(useQueryCache, "false", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| return await SearchImpl(sqlSearchOptions, false, cancellationToken); | ||
| } | ||
| else if (string.Equals(useQueryCache, "both", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| _logger.LogInformation("Running search with and without query cache."); | ||
| var stopwatch = Stopwatch.StartNew(); | ||
|
|
||
| using var tokenSource = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken); | ||
| var token = tokenSource.Token; | ||
|
|
||
| var tryWithQueryCache = SearchImpl(sqlSearchOptions, true, token); | ||
| var tryWithoutQueryCache = SearchImpl(sqlSearchOptions, false, token); | ||
|
|
||
| var result = await Task.WhenAny(tryWithQueryCache, tryWithoutQueryCache); | ||
| await tokenSource.CancelAsync(); | ||
|
|
||
| _logger.LogInformation("First search completed in {ElapsedMilliseconds}ms, query cache enabled: {QueryCacheEnabled}.", stopwatch.ElapsedMilliseconds, result == tryWithQueryCache); | ||
| return await result; | ||
| } |
There was a problem hiding this comment.
Do we want to expose this on such a granular level?
| { | ||
| return await SearchImpl(sqlSearchOptions, false, cancellationToken); | ||
| } | ||
| else if (string.Equals(useQueryCache, "both", StringComparison.OrdinalIgnoreCase)) |
|
I think the description is now out of date for "x-ms-query-latency-over-efficiency" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the x-ms-query-latency-over-efficiency header for Gen2. This makes SQL searches run two searches in parallel, with and without query caching. This helps in situations where one or the other will perform better than the other, but it doubles the load on the DB.
Related issues
Addresses User Story 137387: DDMS: SQL search with and without cache
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch