Addressing Reviewer's Comments

microsoft · Jan 21, 2025 · 6460664 · 6460664
1 parent 82aaa64
commit 6460664
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/src/Microsoft.Health.Fhir.Shared.Api/Modules/SearchModule.cs b/src/Microsoft.Health.Fhir.Shared.Api/Modules/SearchModule.cs
@@ -103,6 +103,7 @@ public void Load(IServiceCollection services)
             };
 
 #if STU3 || R4 || R4B
+            // These converters are required only for R5.
             searchValueConverterExclusions.Add(typeof(CanonicalToReferenceSearchValueConverter));
             searchValueConverterExclusions.Add(typeof(IdentifierToStringSearchValueConverter));
             searchValueConverterExclusions.Add(typeof(IdToReferenceSearchValueConverter));

diff --git a/...osoft.Health.Fhir.Shared.Core/Features/Search/Parameters/SearchParameterToTypeResolver.cs b/...osoft.Health.Fhir.Shared.Core/Features/Search/Parameters/SearchParameterToTypeResolver.cs
@@ -110,8 +110,7 @@ private static EnumerableReturnType Visit(BinaryExpression expression, Context c
             else if (expression.Op == "|" ||
                      expression.Op == "!=" ||
                      expression.Op == "==" ||
-                     expression.Op == "and" ||
-                     expression.Op == "-")
+                     expression.Op == "and")
             {
                 foreach (Expression innerExpression in expression.Arguments)
                 {

diff --git a/test/Microsoft.Health.Fhir.Shared.Tests.E2E/Extensions/ModelExtensions.cs b/test/Microsoft.Health.Fhir.Shared.Tests.E2E/Extensions/ModelExtensions.cs
@@ -3,9 +3,7 @@
 // Licensed under the MIT License (MIT). See LICENSE in the repo root for license information.
 // -------------------------------------------------------------------------------------------------
 
-using System;
 using Hl7.Fhir.Model;
-using Microsoft.Azure.Cosmos.Linq;
 
 namespace Microsoft.Health.Fhir.Tests.E2E.Extensions
 {