Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast-element: Fix parameter name in a volatile decorator JSDoc #7054

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

fast-element: Fix parameter name in a volatile decorator JSDoc #7054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
db0a2a8
fast-element: Simplify fromView condition in attributes
doguabaris Dec 6, 2024
0a21092
fast-element: Update parameter name in setValue method
doguabaris Dec 6, 2024
8f0d498
fast-element: Simplify conditional checks in element-controller
doguabaris Dec 6, 2024
fdf26fd
docs(fast-element): improve JSDoc for AttributeDefinition setValue me…
doguabaris Dec 10, 2024
a75c090
Merge branch 'master' into simplify-conditional-checks
janechu Dec 10, 2024
9fb4760
Restore explicit boolean checks in element-controller methods
doguabaris Dec 10, 2024
8da1db4
Merge branch 'master' into simplify-conditional-checks
janechu Dec 11, 2024
79bbaee
fast-element: Fix parameter name in a volatile decorator JSDoc
doguabaris Dec 11, 2024
c110e96
Merge branch 'master' into fix-volatile-doc
doguabaris Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@microsoft-fast-element-b679d332-e9c0-4e4a-984b-c06481f24caa.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fast-element: Simplify conditional checks in element-controller",
"packageName": "@microsoft/fast-element",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/web-components/fast-element/src/observation/observable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ export function observable(target: {}, nameOrAccessor: string | Accessor): void
* Decorator: Marks a property getter as having volatile observable dependencies.
* @param target - The target that the property is defined on.
* @param name - The property name.
* @param name - The existing descriptor.
* @param descriptor - The existing descriptor.
* @public
*/
export function volatile(
Expand Down