Skip to content

Conversation

cataggar
Copy link
Member

@cataggar cataggar commented Oct 14, 2025

This enabled nullable by default and then adds #nullable disable anywhere it is needed in the current code. This will help ensure new code uses nullable and allows existing code to move to it incrementally. This follows the official guidance for moving to nullable.

Incremental step for

Following step 2 in https://learn.microsoft.com/en-us/dotnet/csharp/nullable-migration-strategies :

Nullable enable as the default: Set this default when you're actively developing new features. You want all new code to benefit from nullable reference types and nullable static analysis. Using this default means you must add a #nullable disable to the top of each file. You'll remove these preprocessor directives as you address the warnings in each file.

3435980 by Copilot in

e9ff160 by Copilot locally.

Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.8%. Comparing base (cf8fa35) to head (8af842c).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1471     +/-   ##
=======================================
- Coverage   89.8%   89.8%   -0.1%     
=======================================
  Files        413     413             
  Lines      33117   33117             
  Branches    2047    2047             
=======================================
- Hits       29767   29766      -1     
  Misses      2935    2935             
- Partials     415     416      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cataggar cataggar marked this pull request as ready for review October 14, 2025 22:52
@cataggar cataggar requested a review from a team as a code owner October 14, 2025 22:52
@cataggar
Copy link
Member Author

The CI build is currently failing due to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant