Skip to content

refactor(cli): clean up compilation config and registry cursor #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
altf4-games wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −11
Open

refactor(cli): clean up compilation config and registry cursor #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/apm_cli/commands/compile/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from __future__ import annotations

import dataclasses
import sys
from pathlib import Path
from typing import TYPE_CHECKING
Expand Down Expand Up @@ -775,15 +776,10 @@ def _coerce_provenance_targets(value):
else:
# Traditional single-file compilation - keep existing logic
# Perform initial compilation in dry-run to get generated body (without constitution)
# TODO: Refactor to use dataclasses.replace() once CompilationConfig fields stabilise
intermediate_config = CompilationConfig(
output_path=config.output_path,
chatmode=config.chatmode,
resolve_links=config.resolve_links,
intermediate_config = dataclasses.replace(
config,
dry_run=True, # force
with_constitution=config.with_constitution,
strategy="single-file",
target=config.target,
)
intermediate_result = compiler.compile(intermediate_config)

Expand Down
5 changes: 1 addition & 4 deletions src/apm_cli/registry/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,7 @@ def list_servers(
servers = self._unwrap_server_list(data)

metadata = data.get("metadata", {})
# Spec is camelCase ``nextCursor``; ``next_cursor`` accepted as a
# transitional kindness for in-tree mock fixtures only.
# TODO(v0.1): drop legacy snake_case once fixtures migrate.
next_cursor = metadata.get("nextCursor") or metadata.get("next_cursor")
next_cursor = metadata.get("nextCursor")

return servers, next_cursor

Expand Down