Added sample interaction telemetry event. #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmetulev
requested changes
Feb 10, 2025
AIDevGallery/Samples/Open Source Models/Language Models/Chat.xaml.cs
Outdated
Show resolved
Hide resolved
| public override PartA_PrivTags PartA_PrivTags => PrivTags.ProductAndServiceUsage; | ||
|
|
||
| public string SampleId { get; } | ||
| public string Model1Id { get; } |
There was a problem hiding this comment.
why not make a models array instead of hardcoding model1, model2, etc?
There was a problem hiding this comment.
Also, since these are not just models - we should think about how we make this more readable and move away from just calling everything model
There was a problem hiding this comment.
These are reflected by the telemetry [EventData], so we should be very clear with what we call them.
We do not have plans on having samples with more than two models/endpoints (only the rag and multipose samples uses this). Adding more than two would make the UI very complex too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: add to other samples after initial review.