-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#113: Semantic Kernel #155
base: main
Are you sure you want to change the base?
Conversation
@nmetulev this sample has some problems, I'm investigating |
@zateutsch I've fixed the sample with a more generic solution (using IChatClient's overload). This will also work well will PhiSilica, so its only a plus :) The package you were referencing have its own implementation of the equivalent of IChatClient for ORT, so we should not use it (it was fixed to the CPU version). |
I don't think we should merge this until I've double checked that that memory leak is gone |
Okay, I took a look at this and everything seems to get garbage collected a lot quicker with I think it should be fine to merge how it is now. @nmetulev |
fixes #113
Needed to add a dependency and update another for this, so would appreciate a double check that nothing went awry.
Also, this sample takes forever to load. Not sure if there is any way around it.