-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#128 and #125: RAG Improvements #129
Conversation
On my machine, I indexed war and piece and it took a minute to index. Without the progress tracking, I wasn't sure if the sample is working. I think we need some progress tracking in there - can you think of a way to add it that works? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left comments on the pr
AIDevGallery/Samples/Open Source Models/Embeddings/RetrievalAugmentedGeneration.xaml.cs
Outdated
Show resolved
Hide resolved
…gmentedGeneration.xaml.cs
AIDevGallery/Samples/Open Source Models/Embeddings/RetrievalAugmentedGeneration.xaml.cs
Outdated
Show resolved
Hide resolved
AIDevGallery/Samples/Open Source Models/Embeddings/RetrievalAugmentedGeneration.xaml
Outdated
Show resolved
Hide resolved
…gmentedGeneration.xaml Co-authored-by: Niels Laute <[email protected]>
@niels9001, should we block this PR on adding the side by side, or can we add it another time? |
No let's get this in, we can add it later. |
fixes #125
fixes #128
Summary of changes:
IndexPDF()
andDoRAG()
towards the top of the file.