Data permission banner and setting #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
niels9001
commented
Jan 24, 2025
•
niels9001
commented
nmetulev
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Looks good to me, but I'd like @gregwoo-microsoft to review the strings before merging
| <ToggleSwitch x:Name="DiagnosticDataToggleSwitch" Toggled="DiagnosticDataToggleSwitch_Toggled" /> | ||
| </toolkit:SettingsCard> | ||
| <TextBlock TextWrapping="Wrap" FontSize="10"> | ||
| <Bold> You're sending required diagnostic data. </Bold> |
There was a problem hiding this comment.
Is there a way we can keep this?
|
Setting should say "Optional diagnostic data" not just "Diagnostic data" |
|
Same thing in the description, it should be "by sharing additional diagnostics data" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.