Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ namespace Microsoft.Agents.AI;
/// </summary>
internal sealed class AgentSessionStateBagValueJsonConverter : JsonConverter<AgentSessionStateBagValue>
{
/// <inheritdoc/>
public override bool HandleNull => true;

/// <inheritdoc/>
public override AgentSessionStateBagValue Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -280,20 +280,53 @@ public void SetValue_OverwriteNullWithValue_ReturnsValue()
Assert.Equal("newValue", result);
}

[Fact]
public void SerializeDeserialize_WithNullValue_SerializesAsNull()
[Theory]
[InlineData(false)]
[InlineData(true)]
public void SerializeDeserialize_WithNullValue_Roundtrips(bool useJsonSerializer)
{
// Arrange
var stateBag = new AgentSessionStateBag();
stateBag.SetValue<string>("nullKey", null);

// Act
var json = stateBag.Serialize();
var restored = useJsonSerializer
? JsonSerializer.Deserialize<AgentSessionStateBag>(
JsonSerializer.Serialize(stateBag, AgentAbstractionsJsonUtilities.DefaultOptions),
AgentAbstractionsJsonUtilities.DefaultOptions)!
: AgentSessionStateBag.Deserialize(json);

// Assert - null values are serialized as JSON null
// Assert
Assert.Equal(JsonValueKind.Object, json.ValueKind);
Assert.True(json.TryGetProperty("nullKey", out var nullElement));
Assert.Equal(JsonValueKind.Null, nullElement.ValueKind);
Assert.Equal(1, restored.Count);
Assert.True(restored.TryGetValue<string>("nullKey", out var value));
Assert.Null(value);
Assert.Null(restored.GetValue<string>("nullKey"));
}

[Theory]
[InlineData(false)]
[InlineData(true)]
public void SerializeDeserialize_WithNullValue_CanOverwrite(bool useJsonSerializer)
{
// Arrange
var stateBag = new AgentSessionStateBag();
stateBag.SetValue<string>("nullKey", null);
var restored = useJsonSerializer
? JsonSerializer.Deserialize<AgentSessionStateBag>(
JsonSerializer.Serialize(stateBag, AgentAbstractionsJsonUtilities.DefaultOptions),
AgentAbstractionsJsonUtilities.DefaultOptions)!
: AgentSessionStateBag.Deserialize(stateBag.Serialize());

// Act
restored.SetValue("nullKey", "replacement");

// Assert
Assert.Equal("replacement", restored.GetValue<string>("nullKey"));
Assert.Equal(1, restored.Count);
}

#endregion
Expand Down
Loading