🚀 github-actions azure deploy #302
Conversation
…MaxOptions'. fix err TypeScript-Node-Starter/src/controllers/api.ts[6, 9]: missing whitespace, 8 files fix bugs of issue 15
fit bugs of issue 15 and some other bugs caused by tslint
port changes from PR #11 and update package.lock from latest npm version
fix: copying issues
Bump tasks.json version from 0.10 to 2.00. Add default build task.
…added recommended extensions using vs code's extensions.json
…me issues with CI
removed yarn
- Attach debug configuration - Scripts: debug, serve-debug, watch-debug - Readme
add attach debug configuration
Update debug configuration
fix: fix lint warnings for test files
this seems a bit crude but allows running the tests and having them take care of setting up the port to use
Added missing "node_modules/*" path mapping to README.
- `request` - `request-promise` `request` first appeared as part of initial commit but it seems to be left-over from non commited implementation: https://git.io/JvgNV `request-promise` was added in different PR but it seems without related code: https://git.io/JvgN6 /cc @naknode Thanks!
➖ remove unused dependencies. Closes microsoft#272
Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.7.1 to 5.7.5. - [Release notes](https://github.com/Automattic/mongoose/releases) - [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md) - [Commits](Automattic/mongoose@5.7.1...5.7.5) Signed-off-by: dependabot[bot] <[email protected]>
Update README.md to frame what this repo is
Documentation link was broken thx to @ReeceLangerock
Thx to @samal84
Co-authored-by: Shane Lanan <[email protected]>
Co-authored-by: Shane Lanan <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
/cc @diberry |
|
@peterblazejewicz How is this PR tested so that it works and then the demo can start working again? |
|
@diberry you're correct, thx! @bmiddha so it works on a machine with hosted agent that can access Docker runtime directly. I don't have access to the project website on azure, but I guess it was never setup using the CI to build and deploy (due to MongoDB image dependency). So technically there is no runtime to properly execute all steps in the pipeline (at least for this very project website). @diberry do you know someone from MS that owns this project? If not I'll ask Orta |
|
@peterblazejewicz - I don't know who owns it - sorry - if you find out, please let me know. |
|
Looks like its not in any of the TypeScript Azure properties, so I don't have access keys to be able to add to the GH actions secret. I think we should probably drop the link. |
brittanydrandolph
force-pushed
the
master
branch
from
fbc1328 to
1e15e8b
Compare
Added GitHub Actions workflow to deploy to Azure Web App.
Will require
AZURE_WEBAPP_PUBLISH_PROFILEsecret to be configured in GitHub.The Azure Web App is also expected to have the environment variables configured (https://docs.microsoft.com/en-us/azure/app-service/configure-common#configure-app-settings)