Skip to content

Conversation

@AZero13
Copy link
Contributor

@AZero13 AZero13 commented Nov 17, 2025

No description provided.

@AZero13 AZero13 requested a review from a team as a code owner November 17, 2025 20:58
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Nov 17, 2025
@StephanTLavavej
Copy link
Member

MSVC doesn't warn about this at its highest settings, but Clang has -Wlogical-op-parentheses, and we've (somewhat reluctantly) arrived at a convention of adding parentheses here.

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Nov 18, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Nov 18, 2025
@StephanTLavavej StephanTLavavej changed the title Fix operator precedence warning Fix operator precedence warning for logical AND and logical OR Nov 18, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Nov 19, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 92dedaa into microsoft:main Nov 19, 2025
44 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Nov 19, 2025
@StephanTLavavej
Copy link
Member

⚠️ 🤫 😺

@AZero13 AZero13 deleted the operator branch November 19, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants