Added more checks to .pre-commit-config.yaml

.clang-format

@@ -124,4 +124,3 @@ StatementMacros:
 TabWidth:        4
 UseTab:          Never
 ...
-

.pre-commit-config.yaml

@@ -1,15 +1,10 @@
 repos:
-    #- repo: https://github.com/pre-commit/pre-commit-hooks
-      #rev: v2.0.0
-      #hooks:
-        #- id: check-added-large-files
-        #- id: check-case-conflict
-        #- id: check-json
-        #- id: check-merge-conflict
-        #- id: check-symlinks
-        #- id: check-yaml
-        #- id: trailing-whitespace
-        #- id: end-of-file-fixer
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v2.0.0
+    hooks:
+      - id: check-added-large-files
+      - id: trailing-whitespace
+      - id: end-of-file-fixer
   - repo: local
     hooks:
     - id: clang-format

CONTRIBUTING.md

@@ -22,4 +22,4 @@ Microsoft SEAL uses a customized `.clang-format` configuration for C++ code styl
 A script `tools/scripts/clang-format-all.sh` is provided to easily format all C++ sources and headers in the `native` directory.
 
 Documentation are mostly written in GitHub-flavored Markdown.
-A line break is required after each full sentence.
+A line break is required after each full sentence.

android/app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml

@@ -2,4 +2,4 @@
 <adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
     <background android:drawable="@drawable/ic_launcher_background" />
     <foreground android:drawable="@drawable/ic_launcher_foreground" />
-</adaptive-icon>
+</adaptive-icon>

android/app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml

@@ -2,4 +2,4 @@
 <adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
     <background android:drawable="@drawable/ic_launcher_background" />
     <foreground android:drawable="@drawable/ic_launcher_foreground" />
-</adaptive-icon>
+</adaptive-icon>

android/build.gradle

@@ -6,11 +6,11 @@ buildscript {
     repositories {
         google()
         jcenter()
-        
+
     }
     dependencies {
         classpath 'com.android.tools.build:gradle:3.6.2'
-        
+
         // NOTE: Do not place your application dependencies here; they belong
         // in the individual module build.gradle files
     }
@@ -20,7 +20,7 @@ allprojects {
     repositories {
         google()
         jcenter()
-        
+
     }
 }
 

android/gradle.properties

@@ -20,4 +20,3 @@ org.gradle.jvmargs=-Xmx1536m
 android.useAndroidX=true
 # Automatically convert third-party libraries to use AndroidX
 android.enableJetifier=true
-

dotnet/examples/7_Performance.cs

@@ -20,7 +20,7 @@ private static void BFVPerformanceTest(SEALContext context)
 
             bool hasZLIB = Serialization.IsSupportedComprMode(ComprModeType.ZLIB);
             bool hasZSTD = Serialization.IsSupportedComprMode(ComprModeType.ZSTD);
-            
+
             using EncryptionParameters parms = context.FirstContextData.Parms;
             using Modulus plainModulus = parms.PlainModulus;
             ulong polyModulusDegree = parms.PolyModulusDegree;

dotnet/examples/Utilities.cs

@@ -186,4 +186,4 @@ public static void PrintLine([CallerLineNumber] int lineNumber = 0)
             Console.Write("Line {0,3} --> ", lineNumber);
         }
     }
-}
+}

dotnet/nuget/NUGET.md

@@ -33,4 +33,4 @@ packages in this known location. In Microsoft Visual Studio 2019, for example, y
 After this, you should be able to add a reference to this package in your own .NET project. After
 creating or opening your project in Visual Studio, you can right click on the project in the
 Solution Explorer window, and select `Manage NuGet packages...`. In the window that appears
-you will be able to select the `Microsoft.Research.SEAL` NuGet package to add to your project.
+you will be able to select the `Microsoft.Research.SEAL` NuGet package to add to your project.

dotnet/src/EncryptionParameterQualifiers.cs

@@ -213,4 +213,4 @@ protected override void DestroyNativeObject()
             NativeMethods.EPQ_Destroy(NativePtr);
         }
     }
-}
+}

dotnet/src/MemoryPoolHandle.cs

@@ -233,4 +233,4 @@ protected override void DestroyNativeObject()
             NativeMethods.MemoryPoolHandle_Destroy(NativePtr);
         }
     }
-}
+}

dotnet/src/SEALContext.cs

@@ -518,4 +518,4 @@ protected override void DestroyNativeObject()
             }
         }
     }
-}
+}

dotnet/src/ValCheck.cs

@@ -152,4 +152,4 @@ public static bool IsValidFor(GaloisKeys galoisKeys, SEALContext context)
             return result;
         }
     }
-}
+}

dotnet/tests/MemoryManagerTests.cs

@@ -33,4 +33,4 @@ public void SwitchProfileTest()
             Assert.IsTrue(globalHandle.IsInitialized);
         }
     }
-}
+}

dotnet/tests/MemoryPoolHandleTests.cs

@@ -96,4 +96,4 @@ public void ExceptionsTest()
             Utilities.AssertThrows<ArgumentNullException>(() => handle.Set(null));
         }
     }
-}
+}

native/examples/CMakeLists.txt

@@ -11,4 +11,4 @@ target_sources(sealexamples
         ${CMAKE_CURRENT_LIST_DIR}/5_rotation.cpp
         ${CMAKE_CURRENT_LIST_DIR}/6_serialization.cpp
         ${CMAKE_CURRENT_LIST_DIR}/7_performance.cpp
-)
+)

native/examples/SEALExamples.vcxproj

@@ -203,4 +203,4 @@
   </ItemGroup>
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
   <ImportGroup Label="ExtensionTargets" />
-</Project>
+</Project>

native/examples/SEALExamples.vcxproj.filters

@@ -49,4 +49,4 @@
       <Filter>Header Files</Filter>
     </ClInclude>
   </ItemGroup>
-</Project>
+</Project>

native/src/SEAL.vcxproj

@@ -353,4 +353,4 @@
   </ItemDefinitionGroup>
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
   <ImportGroup Label="ExtensionTargets" />
-</Project>
+</Project>

native/src/SEAL.vcxproj.filters

@@ -342,4 +342,4 @@
       <Filter>Other</Filter>
     </None>
   </ItemGroup>
-</Project>
+</Project>

native/src/SEAL_C.vcxproj

@@ -265,4 +265,4 @@
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
   <ImportGroup Label="ExtensionTargets">
   </ImportGroup>
-</Project>
+</Project>

native/src/SEAL_C.vcxproj.filters

@@ -193,4 +193,4 @@
       <Filter>Other</Filter>
     </Text>
   </ItemGroup>
-</Project>
+</Project>

native/src/seal/c/defines.h

@@ -56,4 +56,4 @@ static_assert(false, "Require architecture == x64");
 
 #endif // _MSC_VER
 
-#define SEAL_C_FUNC SEAL_C_DECOR HRESULT SEAL_C_CALL
+#define SEAL_C_FUNC SEAL_C_DECOR HRESULT SEAL_C_CALL

native/src/seal/c/dllmain.cpp

@@ -15,4 +15,4 @@ BOOL APIENTRY DllMain(HMODULE hModule, DWORD ul_reason_for_call, LPVOID lpReserv
         break;
     }
     return TRUE;
-}
+}

native/src/seal/c/encryptionparameterqualifiers.h

@@ -33,4 +33,4 @@ SEAL_C_FUNC EPQ_SecLevel(void *thisptr, int *sec_level);
 
 SEAL_C_FUNC EPQ_ParameterErrorName(void *thisptr, char *outstr, uint64_t *length);
 
-SEAL_C_FUNC EPQ_ParameterErrorMessage(void *thisptr, char *outstr, uint64_t *length);
+SEAL_C_FUNC EPQ_ParameterErrorMessage(void *thisptr, char *outstr, uint64_t *length);

native/src/seal/c/galoiskeys.cpp

@@ -26,4 +26,4 @@ SEAL_C_FUNC GaloisKeys_GetIndex(uint32_t galois_elt, uint64_t *index)
     {
         return E_INVALIDARG;
     }
-}
+}

native/src/seal/c/memorymanager.cpp

@@ -162,4 +162,4 @@ SEAL_C_FUNC MMProf_Destroy(void *thisptr)
 
     delete profile;
     return S_OK;
-}
+}

native/src/seal/c/memorypoolhandle.cpp

@@ -133,4 +133,4 @@ SEAL_C_FUNC MemoryPoolHandle_Equals(void *thisptr, void *otherptr, bool *result)
 
     *result = (*pool == *other);
     return S_OK;
-}
+}

native/src/seal/c/relinkeys.cpp

@@ -26,4 +26,4 @@ SEAL_C_FUNC RelinKeys_GetIndex(uint64_t key_power, uint64_t *index)
     {
         return E_INVALIDARG;
     }
-}
+}

native/src/seal/c/sealcontext.h

@@ -37,4 +37,4 @@ SEAL_C_FUNC SEALContext_UsingKeyswitching(void *thisptr, bool *using_keyswitchin
 
 SEAL_C_FUNC SEALContext_ParameterErrorName(void *thisptr, char *outstr, uint64_t *length);
 
-SEAL_C_FUNC SEALContext_ParameterErrorMessage(void *thisptr, char *outstr, uint64_t *length);
+SEAL_C_FUNC SEALContext_ParameterErrorMessage(void *thisptr, char *outstr, uint64_t *length);

native/src/seal/c/version.h

@@ -17,4 +17,4 @@ SEAL_C_FUNC Version_Major(uint8_t *result);
 
 SEAL_C_FUNC Version_Minor(uint8_t *result);
 
-SEAL_C_FUNC Version_Patch(uint8_t *result);
+SEAL_C_FUNC Version_Patch(uint8_t *result);

native/src/seal/memorymanager.cpp

@@ -12,4 +12,4 @@ namespace seal
 #else
 #pragma message("WARNING: MemoryManager compiled thread-unsafe and MMProfGuard disabled to support /clr")
 #endif
-} // namespace seal
+} // namespace seal

native/src/seal/modulus.cpp

@@ -170,4 +170,4 @@ namespace seal
         }
         return result;
     }
-} // namespace seal
+} // namespace seal

native/src/seal/util/dwthandler.h

@@ -359,4 +359,4 @@ namespace seal
             Arithmetic<ValueType, RootType, ScalarType> arithmetic_;
         };
     } // namespace util
-} // namespace seal
+} // namespace seal

native/src/seal/util/numth.cpp

@@ -423,4 +423,4 @@ namespace seal
             return true;
         }
     } // namespace util
-} // namespace seal
+} // namespace seal

native/tests/SEALTest.vcxproj

@@ -201,4 +201,4 @@
     </PropertyGroup>
     <Error Condition="!Exists('..\..\packages\Microsoft.googletest.v140.windesktop.msvcstl.static.rt-dyn.1.8.1.3\build\native\Microsoft.googletest.v140.windesktop.msvcstl.static.rt-dyn.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Microsoft.googletest.v140.windesktop.msvcstl.static.rt-dyn.1.8.1.3\build\native\Microsoft.googletest.v140.windesktop.msvcstl.static.rt-dyn.targets'))" />
   </Target>
-</Project>
+</Project>

native/tests/SEALTest.vcxproj.filters

@@ -152,4 +152,4 @@
   <ItemGroup>
     <None Include="packages.config" />
   </ItemGroup>
-</Project>
+</Project>

native/tests/packages.config

@@ -1,4 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
   <package id="Microsoft.googletest.v140.windesktop.msvcstl.static.rt-dyn" version="1.8.1.3" targetFramework="native" />
-</packages>
+</packages>

native/tests/seal/memorymanager.cpp

@@ -67,4 +67,4 @@ namespace sealtest
         }
         ASSERT_EQ(1L, pool.use_count());
     }
-} // namespace sealtest
+} // namespace sealtest

native/tests/seal/testrunner.cpp

@@ -10,4 +10,4 @@ int main(int argc, char **argv)
 {
     testing::InitGoogleTest(&argc, argv);
     return RUN_ALL_TESTS();
-}
+}

pipelines/android.yml

@@ -14,7 +14,7 @@ steps:
       $ToolsDirectory = Join-Path -Path $Env:BUILD_SOURCESDIRECTORY -ChildPath tools
       $NinjaZipFile = Join-Path $ToolsDirectory -ChildPath ninja.zip
       $NinjaExeFile = Join-Path $ToolsDirectory -ChildPath ninja.exe
-      
+
       Invoke-WebRequest -Uri "https://github.com/ninja-build/ninja/releases/download/v1.10.0/ninja-win.zip" -OutFile $NinjaZipFile
       Expand-Archive -Path $NinjaZipFile -DestinationPath $ToolsDirectory
       Copy-Item -Path $NinjaExeFile -Destination "c:\Program Files\CMake\bin"

pipelines/pipeline-CI-Android.yml

@@ -25,4 +25,3 @@ stages:
       parameters:
         debug: false
         name: Android
-

pipelines/pipeline-CI-Debug-Linux.yml

@@ -24,4 +24,4 @@ stages:
     - template: jobs.yml
       parameters:
         debug: true
-        name: Linux
+        name: Linux

pipelines/pipeline-CI-Debug-Windows.yml

@@ -24,4 +24,4 @@ stages:
     - template: jobs.yml
       parameters:
         debug: true
-        name: Windows
+        name: Windows

pipelines/pipeline-CI-Debug-macOS.yml

@@ -24,4 +24,4 @@ stages:
     - template: jobs.yml
       parameters:
         debug: true
-        name: macOS
+        name: macOS

tools/scripts/clang-format-all.sh

@@ -7,4 +7,4 @@ BASE_DIR=$(dirname "$0")
 SEAL_ROOT_DIR=$BASE_DIR/../../
 shopt -s globstar
 clang-format -i $SEAL_ROOT_DIR/native/**/*.h
-clang-format -i $SEAL_ROOT_DIR/native/**/*.cpp
+clang-format -i $SEAL_ROOT_DIR/native/**/*.cpp

tools/scripts/collect_system_info.sh

@@ -14,7 +14,7 @@ echo "Extracting: cmake -LA $SEALDIR > $CMAKE_ENV"
 cmake -LA $SEALDIR > $CMAKE_ENV
 echo "Extracting: cmake --system-information > $CMAKE_SYSTEM_INFO"
 cmake --system-information > $CMAKE_SYSTEM_INFO
-echo "Extracting: $CMAKE_CXX_COMPILER_CMD -v > $CMAKE_CXX_COMPILER 2>&1" 
+echo "Extracting: $CMAKE_CXX_COMPILER_CMD -v > $CMAKE_CXX_COMPILER 2>&1"
 $CMAKE_CXX_COMPILER_CMD -v 2> $CMAKE_CXX_COMPILER
 
 ARCHIVE_NAME=../system_info.tar