Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextExtractor] Minor UI/Accessibility fixes #36356

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

davidegiacometti
Copy link
Collaborator

Summary of the Pull Request

  • Made narrator announce languages
  • Made narrator announce the cancel button
  • Changed languages list to show the first letter as upper case
  • Fixed margin in order to center the buttons in the top bar

PR Checklist

Detailed Description of the Pull Request / Additional comments

image image

0.86 - PR

image image image

Validation Steps Performed

Manually tested using Narrator

@davidegiacometti davidegiacometti force-pushed the users/davidegiacometti/powerocr-fixes branch from bf3183c to 8f76705 Compare December 15, 2024 21:45
@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Dec 20, 2024
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Seems to fix all accessibility issues linked and everything seemed to still be working. Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit 1eec678 into main Jan 2, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants