Migrate SampleBarChart to new Formatting Model Pane #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d strings localization
…ngSettingsService Modify formatting settings to use formatting model utils service & Add strings localization
remove displayNames from capabilities replace displayNameKey by DisplayName in FormattingSettings
ShereinDabbah
requested review from
AsafMozes,
Roi-Hochler,
anitamayorov,
gekeldaw and
ramizsha
AleksSavelev
approved these changes
Dec 27, 2022
ShereinDabbah
requested review from
AleksSavelev
and removed request for
gekeldaw
AleksSavelev
approved these changes
Jan 6, 2023
|
will this ever be merged? |
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
…d strings localization Signed-off-by: Sherein Dabbah <[email protected]>
remove displayNames from capabilities replace displayNameKey by DisplayName in FormattingSettings Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
…ub.com/microsoft/PowerBI-visuals-sampleBarChart into dev/sdabbah/formattingmodel-interfaces
…ub.com/microsoft/PowerBI-visuals-sampleBarChart into dev/sdabbah/formattingmodel-interfaces Signed-off-by: Sherein Dabbah <[email protected]>
…ub.com/microsoft/PowerBI-visuals-sampleBarChart into dev/sdabbah/formattingmodel-interfaces Signed-off-by: Sherein Dabbah <[email protected]>
This reverts commit 890a500.
| * populate colorSelector object categories formatting properties | ||
| * @param dataPoints | ||
| */ | ||
| populateColorSelector(dataPoints: BarChartDataPoint[]) { |
There was a problem hiding this comment.
This makes the visual tightly bounded to the implementation of the formatting model. Is there any extendible pattern that could be used in case of multiple dynamic properties?
There was a problem hiding this comment.
Can you explain more what do you mean by this comment
added 3 commits
March 30, 2023 13:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.