refactor(test-version-utils): Update compat-workspace structure#27234
refactor(test-version-utils): Update compat-workspace structure#27234
Conversation
… in .npmrc, move only-pnpm script
…ons to pnpm install Any arguments passed after `--` are now forwarded verbatim to the `pnpm install` invocation inside the script, enabling callers to pass flags such as `--lockfile-only` or `--store-dir` without modifying the script. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (37 lines, 6 files), I've queued these reviewers:
How this works
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the compat workspace tooling/config so updateCompatVersions.ts can forward extra CLI args to pnpm install, and the compat workspace install behavior is driven by workspace-local pnpm settings.
Changes:
- Forward extra CLI args from
updateCompatVersions.tstopnpm install. - Add pnpm settings via
.npmrcfor the compat test workspace. - Adjust compat workspace install scripts/paths and packaging ignore rules.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/test/test-version-utils/scripts/updateCompatVersions.ts | Forwards extra script args to pnpm install when regenerating compat lockfile. |
| packages/test/test-version-utils/package.json | Changes postinstall to run pnpm install without explicit --frozen-lockfile. |
| packages/test/test-version-utils/compat-workspaces/full/package.json | Updates preinstall path for only-pnpm script. |
| packages/test/test-version-utils/compat-workspaces/full/.npmrc | Adds pnpm configuration for compat workspace installs. |
| packages/test/test-version-utils/.npmignore | Attempts to ensure compat workspace .npmrc is included in published package. |
Abe27342
changed the title
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Avoids shell-string interpolation of caller-supplied args, which both allowed shell injection and broke for arguments containing spaces/quotes. Uses pnpm.cmd + shell: true on Windows to satisfy Node's CVE-2024-27980 restriction on spawning .cmd shims; in that mode Node still escapes array args for cmd.exe, so arguments remain verbatim.
Description
Addresses some feedback left on #27186 after completion of the PR related to compat-workspace structure & update script.
updateCompatVersions.tsthrough topnpmTest build here.
e2e test run here (note that cache key partial successes on this build are known and should be addressed by #27221).