Skip to content

build: update type test baselines to 2.100.0 on main#27203

Open
tylerbutler wants to merge 1 commit intomicrosoft:mainfrom
tylerbutler:post-release-2.100.0/typetests-main
Open

build: update type test baselines to 2.100.0 on main#27203
tylerbutler wants to merge 1 commit intomicrosoft:mainfrom
tylerbutler:post-release-2.100.0/typetests-main

Conversation

@tylerbutler
Copy link
Copy Markdown
Member

Description

Post-release type test baseline update: reset and regenerate type test baselines on main against the 2.100.0 client release.

Type tests were disabled (typeValidation.disabled: true) for two packages because neither has a viable previous-version entrypoint to generate tests against this cycle:

  • fluid-framework — the default legacy/alpha entrypoint is not exported by fluid-framework@2.100.0 (or by the current package).
  • @fluid-internal/presence-definitions@fluid-internal/presence-definitions@2.100.0 does not export beta. The package was split out from @fluidframework/presence post-2.92 (refactor(client-presence): split into -definitions and -runtime #26994), and the new -definitions package only exposes . and ./internal/*.

Reviewer Guidance

The review process is outlined on this wiki page.

Reset and regenerate type test baselines against 2.100.0 (the most recent
client release). Disable type tests for `fluid-framework` and
`@fluid-internal/presence-definitions` because neither has a viable
previous-version entrypoint to generate tests against this cycle:

- `fluid-framework`: the default `legacy/alpha` entrypoint is not exported
  by `fluid-framework@2.100.0` (or by the current package).
- `@fluid-internal/presence-definitions`: `@fluid-internal/presence-definitions@2.100.0`
  does not export `beta`. The package was split out from `@fluidframework/presence`
  post-2.92 and the new `-definitions` package only exposes `.` and `./internal/*`.
Copilot AI review requested due to automatic review settings April 29, 2026 19:18
@tylerbutler tylerbutler requested review from a team as code owners April 29, 2026 19:18
@github-actions
Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (2460 lines, 126 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

Toggle the reviewer checkboxes above to adjust, then tick the box below to start:

  • Start review

* Generated by "flub generate typetests" from @fluid-tools/build-cli.
*
* Baseline (previous) version: 2.92.0
* Baseline (previous) version: 2.100.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since when did we inline this?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Post-release maintenance PR to regenerate and align TypeScript type-test baselines on main against the 2.100.0 client release, updating the *-previous dependency pins and corresponding generated baseline files. It also disables type validation for packages that cannot generate a viable previous-version entrypoint this cycle.

Changes:

  • Bump *-previous devDependencies (and lockfile entries) from 2.92.0 to 2.100.0.
  • Regenerate validate*Previous.generated.ts baseline files to reflect the new previous version and updated compatibility surfaces.
  • Disable typeValidation for fluid-framework and @fluid-internal/presence-definitions due to missing/invalid previous-version entrypoints.

Reviewed changes

Copilot reviewed 125 out of 126 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pnpm-lock.yaml Updates resolved *-previous packages to 2.100.0 and refreshes dependency graph snapshots accordingly.
packages/utils/tool-utils/src/test/types/validateToolUtilsPrevious.generated.ts Updates generated type-test baseline header to 2.100.0.
packages/utils/tool-utils/package.json Bumps @fluidframework/tool-utils-previous to 2.100.0.
packages/utils/telemetry-utils/src/test/types/validateTelemetryUtilsPrevious.generated.ts Updates baseline header to 2.100.0 and reflects regenerated compat assertions.
packages/utils/telemetry-utils/package.json Bumps @fluidframework/telemetry-utils-previous to 2.100.0.
packages/utils/odsp-doclib-utils/src/test/types/validateOdspDoclibUtilsPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/utils/odsp-doclib-utils/package.json Bumps @fluidframework/odsp-doclib-utils-previous to 2.100.0.
packages/tools/fluid-runner/src/test/types/validateFluidRunnerPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/tools/fluid-runner/package.json Bumps @fluidframework/fluid-runner-previous to 2.100.0.
packages/tools/devtools/devtools/src/test/types/validateDevtoolsPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/tools/devtools/devtools/package.json Bumps @fluidframework/devtools-previous to 2.100.0.
packages/tools/devtools/devtools-core/src/test/types/validateDevtoolsCorePrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/tools/devtools/devtools-core/package.json Bumps @fluidframework/devtools-core-previous to 2.100.0.
packages/test/test-utils/src/test/types/validateTestUtilsPrevious.generated.ts Updates generated baseline header to 2.100.0 and reflects regenerated compat assertions.
packages/test/test-utils/package.json Bumps @fluidframework/test-utils-previous to 2.100.0 and resets typeValidation.broken.
packages/service-clients/tinylicious-client/src/test/types/validateTinyliciousClientPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/service-clients/tinylicious-client/package.json Bumps @fluidframework/tinylicious-client-previous to 2.100.0.
packages/service-clients/azure-client/src/test/types/validateAzureClientPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/service-clients/azure-client/package.json Bumps @fluidframework/azure-client-previous to 2.100.0.
packages/runtime/test-runtime-utils/src/test/types/validateTestRuntimeUtilsPrevious.generated.ts Updates baseline header to 2.100.0 and reflects regenerated compat assertions.
packages/runtime/test-runtime-utils/package.json Bumps @fluidframework/test-runtime-utils-previous to 2.100.0 and resets typeValidation.broken.
packages/runtime/runtime-utils/src/test/types/validateRuntimeUtilsPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/runtime/runtime-utils/package.json Bumps @fluidframework/runtime-utils-previous to 2.100.0.
packages/runtime/runtime-definitions/src/test/types/validateRuntimeDefinitionsPrevious.generated.ts Updates baseline header to 2.100.0 and reflects regenerated compat assertions.
packages/runtime/runtime-definitions/package.json Bumps @fluidframework/runtime-definitions-previous to 2.100.0.
packages/runtime/id-compressor/src/test/types/validateIdCompressorPrevious.generated.ts Updates baseline header to 2.100.0 and reflects regenerated compat assertions.
packages/runtime/id-compressor/package.json Bumps @fluidframework/id-compressor-previous to 2.100.0 and resets typeValidation.broken.
packages/runtime/datastore/src/test/types/validateDatastorePrevious.generated.ts Updates baseline header to 2.100.0 and reflects regenerated compat assertions.
packages/runtime/datastore/package.json Bumps @fluidframework/datastore-previous to 2.100.0 and resets typeValidation.broken.
packages/runtime/datastore-definitions/src/test/types/validateDatastoreDefinitionsPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/runtime/datastore-definitions/package.json Bumps @fluidframework/datastore-definitions-previous to 2.100.0.
packages/runtime/container-runtime/src/test/types/validateContainerRuntimePrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/runtime/container-runtime/package.json Bumps @fluidframework/container-runtime-previous to 2.100.0.
packages/runtime/container-runtime-definitions/src/test/types/validateContainerRuntimeDefinitionsPrevious.generated.ts Updates baseline header to 2.100.0 and reflects regenerated compat assertions.
packages/runtime/container-runtime-definitions/package.json Bumps @fluidframework/container-runtime-definitions-previous to 2.100.0 and resets typeValidation.broken.
packages/loader/driver-utils/src/test/types/validateDriverUtilsPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/loader/driver-utils/package.json Bumps @fluidframework/driver-utils-previous to 2.100.0.
packages/loader/container-loader/src/test/types/validateContainerLoaderPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/loader/container-loader/package.json Bumps @fluidframework/container-loader-previous to 2.100.0.
packages/framework/undo-redo/src/test/types/validateUndoRedoPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/framework/undo-redo/package.json Bumps @fluidframework/undo-redo-previous to 2.100.0.
packages/framework/type-factory/package.json Removes typetests:gen script while typeValidation.disabled is true.
packages/framework/tree-agent/package.json Removes typetests:gen script while typeValidation.disabled is true.
packages/framework/tree-agent-ses/package.json Removes typetests:gen script while typeValidation.disabled is true.
packages/framework/tree-agent-langchain/package.json Removes typetests:gen script while typeValidation.disabled is true.
packages/framework/synthesize/src/test/types/validateSynthesizePrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/framework/synthesize/package.json Bumps @fluidframework/synthesize-previous to 2.100.0.
packages/framework/request-handler/src/test/types/validateRequestHandlerPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/framework/request-handler/package.json Bumps @fluidframework/request-handler-previous to 2.100.0.
packages/framework/presence-definitions/src/test/types/validatePresenceDefinitionsPrevious.generated.ts Removes generated previous-baseline file (type validation disabled for this package).
packages/framework/presence-definitions/package.json Switches previous package reference to @fluid-internal/presence-definitions@2.100.0 and disables type validation.
packages/framework/fluid-static/src/test/types/validateFluidStaticPrevious.generated.ts Updates baseline header to 2.100.0 and reflects regenerated compat assertions.
packages/framework/fluid-static/package.json Bumps @fluidframework/fluid-static-previous to 2.100.0.
packages/framework/fluid-framework/package.json Adds typetests:gen, bumps fluid-framework-previous to 2.100.0, and disables type validation.
packages/framework/dds-interceptions/package.json Removes typetests:gen script while typeValidation.disabled is true.
packages/framework/client-logger/fluid-telemetry/package.json Removes typetests:gen script while typeValidation.disabled is true.
packages/framework/client-logger/app-insights-logger/src/test/types/validateAppInsightsLoggerPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/framework/client-logger/app-insights-logger/package.json Bumps @fluidframework/app-insights-logger-previous to 2.100.0.
packages/framework/attributor/package.json Removes typetests:gen script while typeValidation.disabled is true.
packages/framework/aqueduct/src/test/types/validateAqueductPrevious.generated.ts Updates baseline header to 2.100.0 and reflects regenerated compat assertions.
packages/framework/aqueduct/package.json Bumps @fluidframework/aqueduct-previous to 2.100.0 and resets typeValidation.broken.
packages/framework/agent-scheduler/src/test/types/validateAgentSchedulerPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/framework/agent-scheduler/package.json Bumps @fluidframework/agent-scheduler-previous to 2.100.0.
packages/drivers/tinylicious-driver/src/test/types/validateTinyliciousDriverPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/drivers/tinylicious-driver/package.json Bumps @fluidframework/tinylicious-driver-previous to 2.100.0.
packages/drivers/routerlicious-urlResolver/src/test/types/validateRouterliciousUrlresolverPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/drivers/routerlicious-urlResolver/package.json Bumps @fluidframework/routerlicious-urlresolver-previous to 2.100.0.
packages/drivers/routerlicious-driver/src/test/types/validateRouterliciousDriverPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/drivers/routerlicious-driver/package.json Bumps @fluidframework/routerlicious-driver-previous to 2.100.0.
packages/drivers/replay-driver/src/test/types/validateReplayDriverPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/drivers/replay-driver/package.json Bumps @fluidframework/replay-driver-previous to 2.100.0.
packages/drivers/odsp-urlResolver/src/test/types/validateOdspUrlresolverPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/drivers/odsp-urlResolver/package.json Bumps @fluidframework/odsp-urlresolver-previous to 2.100.0.
packages/drivers/odsp-driver/src/test/types/validateOdspDriverPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/drivers/odsp-driver/package.json Bumps @fluidframework/odsp-driver-previous to 2.100.0.
packages/drivers/odsp-driver-definitions/src/test/types/validateOdspDriverDefinitionsPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/drivers/odsp-driver-definitions/package.json Bumps @fluidframework/odsp-driver-definitions-previous to 2.100.0.
packages/drivers/local-driver/src/test/types/validateLocalDriverPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/drivers/local-driver/package.json Bumps @fluidframework/local-driver-previous to 2.100.0.
packages/drivers/file-driver/src/test/types/validateFileDriverPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/drivers/file-driver/package.json Bumps @fluidframework/file-driver-previous to 2.100.0.
packages/drivers/driver-web-cache/src/test/types/validateDriverWebCachePrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/drivers/driver-web-cache/package.json Bumps @fluidframework/driver-web-cache-previous to 2.100.0.
packages/drivers/driver-base/src/test/types/validateDriverBasePrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/drivers/driver-base/package.json Bumps @fluidframework/driver-base-previous to 2.100.0.
packages/drivers/debugger/src/test/types/validateDebuggerPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/drivers/debugger/package.json Bumps @fluidframework/debugger-previous to 2.100.0.
packages/dds/tree/src/test/types/validateTreePrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/dds/tree/package.json Bumps @fluidframework/tree-previous to 2.100.0.
packages/dds/task-manager/src/test/types/validateTaskManagerPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/dds/task-manager/package.json Bumps @fluidframework/task-manager-previous to 2.100.0.
packages/dds/shared-summary-block/src/test/types/validateSharedSummaryBlockPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/dds/shared-summary-block/package.json Bumps @fluidframework/shared-summary-block-previous to 2.100.0.
packages/dds/shared-object-base/src/test/types/validateSharedObjectBasePrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/dds/shared-object-base/package.json Bumps @fluidframework/shared-object-base-previous to 2.100.0.
packages/dds/sequence/src/test/types/validateSequencePrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/dds/sequence/package.json Bumps @fluidframework/sequence-previous to 2.100.0.
packages/dds/register-collection/src/test/types/validateRegisterCollectionPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/dds/register-collection/package.json Bumps @fluidframework/register-collection-previous to 2.100.0.
packages/dds/ordered-collection/src/test/types/validateOrderedCollectionPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/dds/ordered-collection/package.json Bumps @fluidframework/ordered-collection-previous to 2.100.0.
packages/dds/merge-tree/src/test/types/validateMergeTreePrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/dds/merge-tree/package.json Bumps @fluidframework/merge-tree-previous to 2.100.0.
packages/dds/matrix/src/test/types/validateMatrixPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/dds/matrix/package.json Bumps @fluidframework/matrix-previous to 2.100.0.
packages/dds/map/src/test/types/validateMapPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/dds/map/package.json Bumps @fluidframework/map-previous to 2.100.0.
packages/dds/legacy-dds/package.json Removes typetests:gen script while typeValidation.disabled is true.
packages/dds/ink/package.json Removes typetests:gen script while typeValidation.disabled is true.
packages/dds/counter/src/test/types/validateCounterPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/dds/counter/package.json Bumps @fluidframework/counter-previous to 2.100.0.
packages/dds/cell/src/test/types/validateCellPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/dds/cell/package.json Bumps @fluidframework/cell-previous to 2.100.0.
packages/common/driver-definitions/src/test/types/validateDriverDefinitionsPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/common/driver-definitions/package.json Bumps @fluidframework/driver-definitions-previous to 2.100.0.
packages/common/core-utils/src/test/types/validateCoreUtilsPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/common/core-utils/package.json Bumps @fluidframework/core-utils-previous to 2.100.0.
packages/common/core-interfaces/src/test/types/validateCoreInterfacesPrevious.generated.ts Updates baseline header to 2.100.0 and reflects regenerated compat assertions.
packages/common/core-interfaces/package.json Bumps @fluidframework/core-interfaces-previous to 2.100.0.
packages/common/container-definitions/src/test/types/validateContainerDefinitionsPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/common/container-definitions/package.json Bumps @fluidframework/container-definitions-previous to 2.100.0.
packages/common/client-utils/src/test/types/validateClientUtilsPrevious.generated.ts Updates generated baseline header to 2.100.0.
packages/common/client-utils/package.json Bumps @fluid-internal/client-utils-previous to 2.100.0.
experimental/dds/sequence-deprecated/package.json Removes typetests:gen script while typeValidation.disabled is true.
azure/packages/azure-service-utils/src/test/types/validateAzureServiceUtilsPrevious.generated.ts Updates generated baseline header to 2.100.0.
azure/packages/azure-service-utils/package.json Bumps @fluidframework/azure-service-utils-previous to 2.100.0.

Comment on lines +95 to 97
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist",
"typetests:gen": "flub generate typetests --dir . -v"
},
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeValidation.disabled is set to true, but scripts.typetests:gen is still present. Our typetests normalizer explicitly deletes typetests:gen when disabled (see build-tools/packages/build-cli/src/commands/typetests.ts), and leaving it here can cause fluid-build/repo-policy task dependency resolution to still run typetests generation (or add typetests:gen as a prerequisite for tsc). Remove typetests:gen (and consider normalizing the typeValidation block to just { "disabled": true }).

Copilot uses AI. Check for mistakes.
Comment on lines 72 to 74
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ./src/cjs/package.json ./dist",
"typetests:gen": "flub generate typetests --dir . -v",
"typetests:gen-disabled": "flub generate typetests --dir . -v"
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package has typeValidation.disabled: true but still defines scripts.typetests:gen (and an additional typetests:gen-disabled script). The build-cli typetests normalizer only understands typetests:gen and removes it when disabled; keeping typetests:gen means workspace-wide typetests:gen runs may still attempt generation in a package that is explicitly opted out. Recommend deleting typetests:gen when disabled (and also removing typetests:gen-disabled since it isn’t recognized/used by the tooling).

Copilot uses AI. Check for mistakes.
Comment on lines 122 to 124
"eslint": "catalog:eslint",
"fluid-framework-previous": "npm:fluid-framework@2.92.0",
"fluid-framework-previous": "npm:fluid-framework@2.100.0",
"jiti": "^2.6.1",
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With typeValidation.disabled: true, the fluid-framework-previous devDependency is unused and (per updateTypeTestDependency in build-tools/packages/build-cli/src/commands/typetests.ts) would normally be removed when typetests are normalized/prepared. Consider dropping this dependency while type validation is disabled to avoid extra install surface and keep package.json/lockfile aligned with tooling expectations.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants