Skip to content

Commit 09af602

Browse files
committed
Merged PR 687317: Enable sourcehashes in fingerprintdata when storefingerprint is enabled as well
Sometimes we enable storeFingerprints without runtimecache miss analyzer feature. In those cases, we need to send the source hashes as well.
1 parent 419c004 commit 09af602

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Public/Src/Engine/Scheduler/PipExecutor.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -2274,8 +2274,8 @@ public static async Task<RunnableFromCacheResult> TryCheckProcessRunnableFromCac
22742274
private static void PopulateFingerprintDataWithSourceHashes(BoxRef<ProcessFingerprintComputationEventData> processFingerprintComputationResult, Process pip, IPipExecutionEnvironment environment)
22752275
{
22762276
if (environment.Configuration.EnableDistributedSourceHashing() &&
2277-
environment.Configuration.Logging.CacheMissAnalysisOption.Mode != CacheMissMode.Disabled &&
2278-
environment.Configuration.Distribution.BuildRole == DistributedBuildRoles.Worker)
2277+
environment.Configuration.Distribution.BuildRole == DistributedBuildRoles.Worker &&
2278+
(environment.Configuration.Logging.StoreFingerprints == true || environment.Configuration.Logging.CacheMissAnalysisOption.Mode != CacheMissMode.Disabled))
22792279
{
22802280
// If runtime cache miss analyzer is enabled and source file hashing is distributed, workers will report source file hashes back to the orchestrator
22812281
// because the orchestrator might not have the hashes for all source files.

0 commit comments

Comments
 (0)