Merged PR 687277: Add missing explicit return type in npm SDK

smera · smera · commit 419c00484b4b · 2022-11-04T21:16:01.000Z
This is to make OSGTools validation happy, since they run with [EnforceSomeTypeSanity] rule
diff --git a/Public/Sdk/Public/JavaScript/npm.dsc b/Public/Sdk/Public/JavaScript/npm.dsc
@@ -221,7 +221,7 @@ namespace Npm {
         return result.getOutputDirectory(args.targetDirectory);
     }
 
-    function getNpmCachePath(args: InstallArgumentsCommon) {
+    function getNpmCachePath(args: InstallArgumentsCommon) : Directory {
         // If not specified explicitly, look for the nuget cache folder, otherwise use an arbitrary output folder
         const preserveCacheFolder = args.preserveCacheFolder || false;
 

Original file line number	Diff line number	Diff line change
`@@ -221,7 +221,7 @@ namespace Npm {`
`221`	`221`	`return result.getOutputDirectory(args.targetDirectory);`
`222`	`222`	`}`
`223`	`223`
`224`		`- function getNpmCachePath(args: InstallArgumentsCommon) {`
	`224`	`+ function getNpmCachePath(args: InstallArgumentsCommon) : Directory {`
`225`	`225`	`// If not specified explicitly, look for the nuget cache folder, otherwise use an arbitrary output folder`
`226`	`226`	`const preserveCacheFolder = args.preserveCacheFolder \|\| false;`
`227`	`227`