Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental Builds #1304
base: main
Are you sure you want to change the base?
Incremental Builds #1304
Changes from 196 commits
cd0d861
5277c11
b008537
d1f9900
aaeaa3d
794d1a9
49b0710
a047541
2d1bc93
4e9fe58
e8421a2
973b91e
6f5275e
6455d85
8eb6807
d85db5d
d9288d0
1fc4c54
1cf1db3
fd92f2b
91ad0d5
2af02e1
faf913f
382fba1
bc29279
ce1abbb
dc3ebc4
c8f4593
53e2e78
d82a4e4
0a7ad8f
2eef1ce
9a17928
ce85f89
6d5c2ee
e9279be
a007fa1
8833217
78c2047
5781265
987c7a7
24dc50d
3e7f0d5
c300bbf
7e85650
3fbef9d
2f5970a
1591d40
5a83ef8
38ef283
2775342
293d4b7
232ff01
32120fc
c5b3dcd
173aaef
b5af39a
34b94b4
8f4dab5
1451f4b
9cd8e28
c3d0daf
2694ea5
a294a9e
cff8a34
702e818
742c41b
ddc3d07
2e304a5
aa316d5
e74238c
90a1255
64290ca
c217a7e
3ef3aae
768d052
9840475
9309ae2
507ea1e
c07156c
a1b2ee4
95f92d5
76880c2
e6969a6
b104f8f
e8e9031
cc4f7f5
5a62b54
604c1fe
ff99ecd
b7360be
e80fe8d
2640c11
23baf93
145df8e
47c558c
a5e9fc9
cc0bad9
422315a
4f90bfd
391b53e
f138883
08171ea
b4b0f86
b58819e
9ad517a
07286b7
674e4e3
8bdae86
ff59a9b
2b641ba
3d4e8b2
eb1c5c8
0c7e42b
d84bfa7
f19cdc7
ef088b0
d1236b5
596edd8
263235a
631624c
db3a07d
fa8e388
f6aa3cc
057e5be
86c28cc
748a501
5c49073
2692a96
8f261c2
abf4f59
0613613
1d668d8
c565875
07cd036
eb7d483
f52120c
8bec033
0642e8b
4e8572f
a371a9b
0d2ae93
72ccf70
83cb87c
a4b46f6
e3e59f7
3d883ee
8e09a7a
2aa69e7
4b50bd8
aae75b7
7e1178e
faf8f90
1f2a607
665e84f
f9303e3
39547d9
60f0b2f
0f934ff
61a6a77
23bb87f
020dfa5
796ccdb
dfb42b8
0b68f06
ab06358
c334581
4516ae9
8e578b5
c6be36e
dd1dee0
53c2414
ca1b3b7
e6f2eea
619c5b4
6dc589b
be1253c
17e571a
9596353
6ce0007
5b0c838
932ab42
466f671
8a8bc7c
360d6db
3f61918
274aacd
b84b4d1
ca7cdbe
99745be
cfd9e87
6252d0d
f053d67
fbcd0e2
8d88d67
1fa094c
7c1a37e
fdbef48
332e2cc
a068ef1
46a1fae
43b0770
0b73f18
0a2a2f1
6d26d7e
469bd0c
50fa2d2
79543b8
890dbf3
1910274
fb7002a
90a752b
aa3fdde
8f431aa
3bd5805
f259633
61ee3f1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall quite well if there was an agreement about these settings that are dynamically determined.
But my opinion is that we should try to avoid them, as we cannot include them in a JSON schema, for example.
Why not have a
workflowConcurrency
setting that could be set either on workflow-level or maybe as a conditional setting?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will consider how to change this with the other workflow base-name settings in mind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to add tests for the new action?