Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logic for Increment Version Number #1108

Merged
merged 17 commits into from
Jun 24, 2024

Conversation

aholstrup1
Copy link
Collaborator

@aholstrup1 aholstrup1 commented Jun 19, 2024

Problem
If you define the repoVersion in .github/AL-Go-Settings.json it isn't updated when running the Increment Version Number workflow. In our case, the would like to keep the repoVersion the same across all Al-Go projects so having repoVersion defined on repo level makes sense for us (even if it is a project setting)

Proposed Solution

  • If repoVersion exists on project level (recommended), we only update it there.
  • If repoVersion doesn't exist in project level but exists on repo level, we update it on repo level (what we want in our case)
  • if repoVersion is neither defined on project level or repo level, force create it on project level

Fixes #1105

@aholstrup1 aholstrup1 requested a review from a team as a code owner June 19, 2024 11:38
mazhelez
mazhelez previously approved these changes Jun 19, 2024
Copy link
Collaborator

@mazhelez mazhelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay.

Is there a way to cover the functionality in tests?

@freddydk
Copy link
Contributor

Looking at the PR description:

  • if repoVersion is neither defined on project level or repo level, force create it on repo level
  • if projects is * then we update the repoVersion both on project level and repo level (if they already exist)

According to the code - it looks like it is force created on the project level if it doesn't exist (which I think is correct) - meaning that the description is wrong, right?

On the last line - I don't think we are updating the repoversion on the repo level if it exists in all projects - do we?

@aholstrup1
Copy link
Collaborator Author

Looking at the PR description:

  • if repoVersion is neither defined on project level or repo level, force create it on repo level
  • if projects is * then we update the repoVersion both on project level and repo level (if they already exist)

According to the code - it looks like it is force created on the project level if it doesn't exist (which I think is correct) - meaning that the description is wrong, right?

On the last line - I don't think we are updating the repoversion on the repo level if it exists in all projects - do we?

You're right :) The description was wrong. It should reflect the code now.

mazhelez
mazhelez previously approved these changes Jun 20, 2024
Copy link
Contributor

@freddydk freddydk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update releasenotes with a comment on this change (or at least the issue fixed)

freddydk
freddydk previously approved these changes Jun 24, 2024
freddydk
freddydk previously approved these changes Jun 24, 2024
mazhelez
mazhelez previously approved these changes Jun 24, 2024
@freddydk freddydk merged commit c9e9cc3 into microsoft:main Jun 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increment Version Number - repoVersion in .github/AL-Go-Settings.json is not updated
3 participants