-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logic for Increment Version Number #1108
Update logic for Increment Version Number #1108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay.
Is there a way to cover the functionality in tests?
Looking at the PR description:
According to the code - it looks like it is force created on the project level if it doesn't exist (which I think is correct) - meaning that the description is wrong, right? On the last line - I don't think we are updating the repoversion on the repo level if it exists in all projects - do we? |
You're right :) The description was wrong. It should reflect the code now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update releasenotes with a comment on this change (or at least the issue fixed)
…rup/incrementversionnumber
…/aholstrup1/al-go into aholstrup/incrementversionnumber
Problem
If you define the repoVersion in .github/AL-Go-Settings.json it isn't updated when running the Increment Version Number workflow. In our case, the would like to keep the repoVersion the same across all Al-Go projects so having repoVersion defined on repo level makes sense for us (even if it is a project setting)
Proposed Solution
Fixes #1105