Add ability to override AWS endpoints during configuration discovery. #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tible to support configuration discovery via Localstack.
|
|
ammeek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is not possible to override the AWS SSM/ secret manager endpoint during configuration discovery. This stops you from being able to integrate Localstack during the configuration discovery process.
I've added the BootstrapContextCompatible annotation to the AWSServiceConfigurationProperties class to resolve this.
I've also added a test to check that this annotation has been added as I have seen similar tests throughout the project.
I am not sure if additional testing showing the configuration discovery process integrating with Localstack is required.