perf(screenshot): offload white-image detection to worker#665
Open
perf(screenshot): offload white-image detection to worker#665
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
A stale worker's `exit` handler could fire after a replacement worker was already created, incorrectly rejecting the new worker's pending promises and clearing its reference. Guard `error` and `exit` handlers with an identity check so they become no-ops once replaced. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Introduces a long-lived
worker_threadsworker with request tracking and lifecycle/error handling; bugs here could cause hangs or incorrect blank-screenshot detection under load despite added coverage.Overview
Offloads
is-white-screenshotimage analysis to a dedicatedworker_threadsworker, extracting the Jimp-based sampling logic intois-white-screenshot-analyze.jsand adding a message-based RPC layer with in-flight request tracking.Adds worker lifecycle handling (reuse,
unref, reject all pending onerror/exit, reset on failure) and new tests that assert worker usage, proper rejection when the worker exits, and safe recovery after a crash; updates the sampling test to targetanalyzedirectly.Written by Cursor Bugbot for commit 89ac764. This will update automatically on new commits. Configure here.