perf(browserless): retry only transient context reset errors#663
Merged
perf(browserless): retry only transient context reset errors#663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: narrows retry behavior to a single known transient error code and adds targeted tests; main risk is reduced resiliency if other errors were previously (incorrectly) being masked by retries.
Overview
withPagenow retries only when the failure is a transient browser-context connection reset (EBRWSRCONTEXTCONNRESET), and immediately rethrows any other error instead of recreating the context and retrying.Adds test coverage to ensure non-transient errors are not retried and that transient context disconnections do retry and recover.
Written by Cursor Bugbot for commit f8418da. This will update automatically on new commits. Configure here.